Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277762: Allow configuration of HOTSPOT_BUILD_USER #6542

Closed
wants to merge 5 commits into from

Conversation

andrew-m-leonard
Copy link

@andrew-m-leonard andrew-m-leonard commented Nov 24, 2021

To better allow "reproducible builds", a new configure parameter is added to set the USERNAME build variable, rather than always using the current user:
--with-build-user=
HOTSPOT_BUILD_USER is then set to a reproducible USERNAME if required.

Signed-off-by: Andrew Leonard anleonar@redhat.com


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277762: Allow configuration of HOTSPOT_BUILD_USER

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6542/head:pull/6542
$ git checkout pull/6542

Update a local copy of the PR:
$ git checkout pull/6542
$ git pull https://git.openjdk.java.net/jdk pull/6542/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6542

View PR using the GUI difftool:
$ git pr show -t 6542

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6542.diff

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 24, 2021

👋 Welcome back aleonard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 24, 2021

@andrew-m-leonard The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Nov 24, 2021
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@openjdk openjdk bot added the rfr label Nov 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 24, 2021

Webrevs

make/autoconf/basic.m4 Outdated Show resolved Hide resolved
@andrew-m-leonard
Copy link
Author

@andrew-m-leonard andrew-m-leonard commented Dec 1, 2021

@erikj79 ready for review again please
thanks

erikj79
erikj79 approved these changes Dec 1, 2021
Copy link
Member

@erikj79 erikj79 left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Dec 1, 2021

@andrew-m-leonard This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277762: Allow configuration of HOTSPOT_BUILD_USER

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 9b3e672: 8278014: [vectorapi] Remove test run script
  • 1e9ed54: 8193682: Infinite loop in ZipOutputStream.close()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 1, 2021
@andrew-m-leonard
Copy link
Author

@andrew-m-leonard andrew-m-leonard commented Dec 1, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 1, 2021

Going to push as commit f41e768.
Since your change was applied there have been 3 commits pushed to the master branch:

  • a363b7b: 8177819: DateTimeFormatterBuilder zone parsing should recognise DST
  • 9b3e672: 8278014: [vectorapi] Remove test run script
  • 1e9ed54: 8193682: Infinite loop in ZipOutputStream.close()

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 1, 2021

@andrew-m-leonard Pushed as commit f41e768.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
2 participants