Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270435: UT: MonitorUsedDeflationThresholdTest failed: did not find too_many string in output #6543

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Nov 24, 2021

A trivial fix to allow MonitorUsedDeflationThresholdTest to tolerate a burst of used
monitors by threads not under the test's control. By lowering the value for
MonitorUsedDeflationThreshold from the default 90% to 10%, we ensure that the
test will hit NoAsyncDeflationProgressMax at least 3 times in 10 seconds in the
non-UT configuration. The burst of monitor usage by UT should no longer prevent
the test from hitting NoAsyncDeflationProgressMax at least twice. In order to pass,
the test only needs to hit NoAsyncDeflationProgressMax once.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8270435: UT: MonitorUsedDeflationThresholdTest failed: did not find too_many string in output

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6543/head:pull/6543
$ git checkout pull/6543

Update a local copy of the PR:
$ git checkout pull/6543
$ git pull https://git.openjdk.java.net/jdk pull/6543/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6543

View PR using the GUI difftool:
$ git pr show -t 6543

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6543.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 24, 2021

/label add hotspot-runtime

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 24, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime label Nov 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 24, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 24, 2021

This fix is being tested with Mach5 Tier[167].

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 25, 2021

Mach5 Tier[167] results are good.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Nov 25, 2021
@openjdk openjdk bot added the rfr label Nov 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 25, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Seems quite reasonable.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270435: UT: MonitorUsedDeflationThresholdTest failed: did not find too_many string in output

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • a81e4fc: 8258117: jar tool sets the time stamp of module-info.class entries to the current time
  • 26472bd: 8277811: ProblemList vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java
  • b5841ba: 8277806: 4 tools/jar failures per platform after JDK-8272728
  • e785f69: 8276124: Provide snippet support for properties files
  • 96fe1d0: 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL"
  • 077b2de: 8274161: Cleanup redundant casts in jdk.compiler
  • 951247c: 8235876: Misleading warning message in java source-file mode
  • 663e33d: 8272728: javac ignores any -J option in @argfiles silently
  • 0384739: 8276665: ObjectInputStream.GetField.get(name, object) should throw ClassNotFoundException
  • cf7adae: 8275320: NMT should perform buffer overrun checks
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/7b2d823e842e6a66dbe46b048da44ca9e5485c75...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 25, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 25, 2021

@dholmes-ora - Thanks for the review. It wasn't clear
whether you agree that this is a trivial fix.

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Nov 25, 2021

Sorry I missed the cue. Yes I agree this is trivial.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Nov 25, 2021

Thanks for confirming.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2021

Going to push as commit 21e302a.
Since your change was applied there have been 16 commits pushed to the master branch:

  • a81e4fc: 8258117: jar tool sets the time stamp of module-info.class entries to the current time
  • 26472bd: 8277811: ProblemList vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java
  • b5841ba: 8277806: 4 tools/jar failures per platform after JDK-8272728
  • e785f69: 8276124: Provide snippet support for properties files
  • 96fe1d0: 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL"
  • 077b2de: 8274161: Cleanup redundant casts in jdk.compiler
  • 951247c: 8235876: Misleading warning message in java source-file mode
  • 663e33d: 8272728: javac ignores any -J option in @argfiles silently
  • 0384739: 8276665: ObjectInputStream.GetField.get(name, object) should throw ClassNotFoundException
  • cf7adae: 8275320: NMT should perform buffer overrun checks
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/7b2d823e842e6a66dbe46b048da44ca9e5485c75...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 25, 2021

@dcubed-ojdk Pushed as commit 21e302a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8270435 branch Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
2 participants