Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277811: ProblemList vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java #6547

Closed
wants to merge 2 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Nov 24, 2021

A couple of trivial ProblemListings:

JDK-8277811 ProblemList vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java
JDK-8277813 ProblemList vmTestbase/nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8277811: ProblemList vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java
  • JDK-8277813: ProblemList vmTestbase/nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6547/head:pull/6547
$ git checkout pull/6547

Update a local copy of the PR:
$ git checkout pull/6547
$ git pull https://git.openjdk.java.net/jdk pull/6547/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6547

View PR using the GUI difftool:
$ git pr show -t 6547

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6547.diff

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Nov 24, 2021

/label add hotspot-runtime
/label add serviceability

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Nov 24, 2021
@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@dcubed-ojdk
The serviceability label was successfully added.

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Nov 24, 2021

/issue JDK-8277811
/issue JDK-8277813

@openjdk openjdk bot changed the title Jdk 8277811 8277811: ProblemList vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277811: ProblemList vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java
8277813: ProblemList vmTestbase/nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8277813: ProblemList vmTestbase/nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java.

@mlbridge
Copy link

mlbridge bot commented Nov 24, 2021

Webrevs

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented Nov 24, 2021

@dholmes-ora - Thanks for the fast review!

/integrate

@openjdk
Copy link

openjdk bot commented Nov 24, 2021

Going to push as commit 26472bd.

@openjdk openjdk bot closed this Nov 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@dcubed-ojdk Pushed as commit 26472bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8277811 branch Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants