8277814: ConcurrentRefineThread should report rate when deactivating

[kimbarrett]

Please review this change to the logging by concurrent refinement threads.
This change adds the cards processed per ms to the deactivation log message.

Testing:
mach5 tier1
locally ran a test with gc+refine=debug logging enabled and verified the
expected change to the deactivation log message.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8277814: ConcurrentRefineThread should report rate when deactivating

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer) ⚠️ Review applies to b623710
• Stefan Johansson (@kstefanj - Reviewer) ⚠️ Review applies to b623710

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6550/head:pull/6550
$ git checkout pull/6550

Update a local copy of the PR:
$ git checkout pull/6550
$ git pull https://git.openjdk.java.net/jdk pull/6550/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6550

View PR using the GUI difftool:
$ git pr show -t 6550

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6550.diff

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (b1efd950)
• 00: Full (b623710c)

[tschatzl]

Not sure how this is used, but in similar calculations we only use and return a value if the elapsed time is large enough (something like a microsecond or so) to remove extreme outliers. Not sure if that is needed here too.

[kimbarrett]

This change only uses it for logging. I could just drop this function and do the equivalent calculation at the point where it's used. I don't think a made up lower limit really makes that much sense anyway; I remember some places like you describe, but I thought many had been eliminated. I could only find a couple. The expectation here is that refined_cards() is probably also zero, unless the time granularity is rather coarse.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277814: ConcurrentRefineThread should report rate when deactivating

Reviewed-by: tschatzl, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kstefanj]

Looks good.

[kimbarrett]

Thanks @tschatzl and @kstefanj for reviews.

[kimbarrett]

/integrate

[openjdk]

Going to push as commit dd73e3c.

[openjdk]

@kimbarrett Pushed as commit dd73e3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.