Skip to content

8254769: Remove unimplemented BCEscapeAnalyzer::{add_dependence, propagate_dependencies} #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 14, 2020

These methods are not implemented, and there were no definitions since the initial load. Can be removed.

Testing:

  • Linux x86_64 build
  • Text searches for add_dependence and propagate_dependencies in src/hotspot

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8254769: Remove unimplemented BCEscapeAnalyzer::{add_dependence, propagate_dependencies}

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/656/head:pull/656
$ git checkout pull/656

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 14, 2020
@openjdk
Copy link

openjdk bot commented Oct 14, 2020

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 14, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 14, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 14, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254769: Remove unimplemented BCEscapeAnalyzer::{add_dependence, propagate_dependencies}

Reviewed-by: thartmann, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 14, 2020
@shipilev
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Oct 15, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 15, 2020
@openjdk
Copy link

openjdk bot commented Oct 15, 2020

@shipilev Since your change was applied there have been 19 commits pushed to the master branch:

  • 7e5eb49: 8253402: Convert vmSymbols::SID to enum class
  • 038f58d: 8226236: [TESTBUG] win32: gc/metaspace/TestCapacityUntilGCWrapAround.java fails
  • 5194f11: 8254792: Disable intrinsic StringLatin1.indexOf until 8254790 is fixed
  • 55d760d: 8254263: Remove special_runtime_exit_condition() check from ~ThreadInVMForHandshake()
  • 03fa733: 8254777: Remove unimplemented Management::get_loaded_classes
  • 8fb294a: 8254781: Remove unimplemented ClassFieldMap::compute_field_count
  • da2f5ab: 8254780: EnterInterpOnlyModeClosure::completed() always returns true
  • 0c99b19: 8223347: Integration of Vector API (Incubator)
  • 386e7e8: 8254789: ProblemList compiler/graalunit/HotspotTest.java
  • cd33abb: 8249623: test @Ignore-d due to 7013634 should be returned back to execution
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/dc262dfcbf89c6cbefda63fea00de7e795bfd883...master

Your commit was automatically rebased without conflicts.

Pushed as commit 81a8ff1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8254769-unimpl-bca branch October 19, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants