8277789: G1: G1CardSetConfiguration prefixes num_ and max_ used interchangeably

[walulyai]

Hi all,

Please review this small refactoring to consistently use prefix max_ for variable names where the variable represents a limit in G1CardSetConfiguration.

Thanks

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8277789: G1: G1CardSetConfiguration prefixes num_ and max_ used interchangeably

Reviewers

• Hamlin Li (@Hamlin-Li - Reviewer) ⚠️ Review applies to ceb50a6
• Thomas Schatzl (@tschatzl - Reviewer) ⚠️ Review applies to ceb50a6

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6567/head:pull/6567
$ git checkout pull/6567

Update a local copy of the PR:
$ git checkout pull/6567
$ git pull https://git.openjdk.java.net/jdk pull/6567/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6567

View PR using the GUI difftool:
$ git pr show -t 6567

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6567.diff

[bridgekeeper]

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@walulyai The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (886ee68e)
• 00: Full (ceb50a6a)

[openjdk]

@walulyai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277789: G1: G1CardSetConfiguration prefixes num_ and max_ used interchangeably

Reviewed-by: mli, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 3d810ad: 8277411: C2 fast_unlock intrinsic on AArch64 has unnecessary ownership check
• ce0234b: 8277860: PPC: Remove duplicate info != NULL check
• 040b2c5: 8277139: Improve code readability in PredecessorValidator (c1_IR.cpp)
• 3e798dd: 8275330: C2: assert(n->is_Root() || n->is_Region() || n->is_Phi() || n->is_MachMerge() || def_block->dominates(block)) failed: uses must be dominated by definitions
• 99e4bda: 8277417: C1 LIR instruction for load-klass
• 00a6238: 8277508: need to check has_predicated_vectors before calling scalable_predicate_reg_slots
• 3383c0d: 8277659: [TESTBUG] Microbenchmark ThreadOnSpinWaitProducerConsumer.java hangs
• 7e54d06: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories
• eb4d886: 8277504: Use String.stripTrailing instead of hand-crafted method in SwingUtilities2
• 9879920: 8277825: Remove unused ReferenceProcessorPhaseTimes::_sub_phases_total_time_ms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Lgtm apart from that small proposed comment update.

[tschatzl]

Maybe add a "Maximum" here too.

[walulyai]

Thanks @Hamlin-Li and @tschatzl for the reviews

/integrate

[openjdk]

Going to push as commit ad51d06.
Since your change was applied there have been 26 commits pushed to the master branch:

• 614c6e6: 8277878: Fix compiler tests after JDK-8275908
• 960bdde: 8277904: G1: Remove G1CardSetArray::max_entries
• 45e8973: 8277896: Remove unused BOTConstants member methods
• e5676f8: 8277450: Record number of references into collection set during gc
• 2622ab3: 8277928: Fix compilation on macosx-aarch64 after 8276108
• 37de442: 8275241: Unused ArrayList is created in RequestEngine.addHooks
• 72bacf8: 8276108: Wrong instruction generation in aarch64 backend
• e3e5908: 8277847: Support toolGuide tag in class-level documentation
• 9a3a9b1: 8277865: G1: Change integer division to floating point division
• aed53ee: 8264838: IGV: enhance graph export functionality
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/f788834998eeb9083e971857446321ed173aa916...master

Your commit was automatically rebased without conflicts.

[openjdk]

@walulyai Pushed as commit ad51d06.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.