-
Notifications
You must be signed in to change notification settings - Fork 6k
8277854: The upper bound of GCCardSizeInBytes should be limited to 512 for 32-bit platforms #6569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…2 for 32-bit platforms
👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into |
@DamonFool The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Several initial comments:
|
Good questions!
Not sure if there is any benefit to distinguish the lower bounds between 32-bit and 64-bit platforms.
Maybe not since no VM flags are added or removed and jdk18 hasn't been released yet.
There is already a jtreg test runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java for this regression. Thanks. |
Thanks for spotting this - that slipped past our testing (we do not do much 32 bit testing).
I will talk to the CSR team whether there needs to be an amendment to the CSR for 32 bit platforms. please do not integrate before this has been handled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good, but I had to amend the CSR (https://bugs.openjdk.java.net/browse/JDK-8275142) for it for this case. As soon as it has been approved again sometime next week, this change can be integrated.
Also fixed the release note.
@DamonFool This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Sure. |
I'm fine with it.
Please follow Thomas's suggestion.
I was wondering why it's not caught by regionion test until I saw Thomas' response. Thanks for clarifying and fixing this. |
Thanks @Hamlin-Li for your review. |
/csr needed We need a new CSR for this change after all (see https://bugs.openjdk.java.net/browse/JDK-8277891). |
@tschatzl this pull request will not be integrated until the CSR request JDK-8277891 for issue JDK-8277854 has been approved. |
The CSR had been approved. /integrate |
Going to push as commit 3a4a94e.
Your commit was automatically rebased without conflicts. |
@DamonFool Pushed as commit 3a4a94e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java crashes on linux/x86_32 with
-XX:GCCardSizeInBytes=1024
.This is because if
-XX:GCCardSizeInBytes=1024
thenBOTConstants::N_words
[1] would be 256.Then the guarantee [2] always fails due to _bot->offset_array(start_card), which is a u_char value, never equals to 256.
So for 32-bit platforms, the upper bound of
GCCardSizeInBytes
should be limited to 512.Thanks.
Best regards,
Jie
[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/gc/shared/blockOffsetTable.cpp#L45
[2] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/gc/g1/g1BlockOffsetTable.cpp#L186
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6569/head:pull/6569
$ git checkout pull/6569
Update a local copy of the PR:
$ git checkout pull/6569
$ git pull https://git.openjdk.java.net/jdk pull/6569/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6569
View PR using the GUI difftool:
$ git pr show -t 6569
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6569.diff