Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277860: PPC: Remove duplicate info != NULL check #6571

Closed
wants to merge 1 commit into from

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Nov 26, 2021

I made a mistake: I should have fixed the duplicated info != NULL check in LIR_Assembler::emit_load_klass() in c1_LIRAssembler_ppc.cpp but forgot until the second I sent the integrate command.

I have no access to PPC hardware, I am sending this blindly, relying only on GHA tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277860: PPC: Remove duplicate info != NULL check

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6571/head:pull/6571
$ git checkout pull/6571

Update a local copy of the PR:
$ git checkout pull/6571
$ git pull https://git.openjdk.java.net/jdk pull/6571/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6571

View PR using the GUI difftool:
$ git pr show -t 6571

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6571.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 26, 2021

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2021

@rkennke The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Nov 26, 2021
Copy link
Member

@chhagedorn chhagedorn left a comment

Looks good and trivial!

@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2021

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277860: PPC: Remove duplicate info != NULL check

Reviewed-by: chagedorn, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 040b2c5: 8277139: Improve code readability in PredecessorValidator (c1_IR.cpp)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 26, 2021

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Thanks for fixing it! I've given it a quick spin on real hardware.

@rkennke
Copy link
Contributor Author

@rkennke rkennke commented Nov 26, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2021

Going to push as commit ce0234b.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 040b2c5: 8277139: Improve code readability in PredecessorValidator (c1_IR.cpp)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2021

@rkennke Pushed as commit ce0234b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants