8277328: jdk/jshell/CommandCompletionTest.java failures on Windows

[lahodaj]

The CommandCompletionTest.java#testUserHome test picks an existing file or directory in the user's home directory, and uses it to validate the behavior of completion after '~/'. The test fails if the test picks a directory with space.

This is not solely a problem in the test - JShell does not handle paths with spaces. The proposed solution is to allow spaces in paths to be escaped with '', and adjust tests accordingly.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8277328: jdk/jshell/CommandCompletionTest.java failures on Windows

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6578/head:pull/6578
$ git checkout pull/6578

Update a local copy of the PR:
$ git checkout pull/6578
$ git pull https://git.openjdk.java.net/jdk pull/6578/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6578

View PR using the GUI difftool:
$ git pr show -t 6578

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6578.diff

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6dcc11c0)

[vicente-romero-oracle]

lgtm

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277328: jdk/jshell/CommandCompletionTest.java failures on Windows

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 166 new commits pushed to the master branch:

• 70bad89: 8277497: Last column cell in the JTAble row is read as empty cell
• 5045eb5: 8278273: Remove unnecessary exclusion of doclint accessibility checks
• 587e540: 8210558: serviceability/sa/TestJhsdbJstackLock.java fails to find '^\s+- waiting to lock <0x[0-9a-f]+> (a java.lang.Class ...'
• 082fdf4: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
• ab78187: 8277105: Inconsistent handling of missing permitted subclasses
• adf3952: 8277372: Add getters for BOT and card table members
• 7c6f57f: 8275610: C2: Object field load floats above its null check resulting in a segfault
• a885aab: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
• 6994d80: 8278291: compiler/uncommontrap/TraceDeoptimizationNoRealloc.java fails with release VMs after JDK-8154011
• 286a26c: 8278277: G1: Simplify implementation of G1GCPhaseTimes::record_or_add_time_secs
• ... and 156 more: https://git.openjdk.java.net/jdk/compare/0384739afc2d470ab6a3525e9d85aca0af58f2ed...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

Going to push as commit 3955b03.
Since your change was applied there have been 189 commits pushed to the master branch:

• 5a036ac: 8277990: NMT: Remove NMT shutdown capability
• 7217cb7: 8274883: (se) Selector.open throws IAE when the default file system provider is changed to a custom provider
• 7ea4b19: 8278166: java/nio/channels/Channels/TransferTo.java timed out
• 543d1a8: 8275721: Name of UTC timezone in a locale changes depending on previous code
• bd7c54a: 8278341: Liveness check for global scope is not as fast as it could be
• c609b5d: 8277628: Spec for InetAddressResolverProvider::get() throwing error or exception could be clearer
• bb50b92: 8277536: Use String.blank in jdk.javadoc where applicable
• 5b81d5e: 8276901: Implement UseHeavyMonitors consistently
• 69d8669: 8278339: ServerSocket::isClosed may return false after accept throws
• 56ca66e: 8277863: Deprecate sun.misc.Unsafe methods that return offsets
• ... and 179 more: https://git.openjdk.java.net/jdk/compare/0384739afc2d470ab6a3525e9d85aca0af58f2ed...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit 3955b03.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.