Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277904: G1: Remove G1CardSetArray::max_entries #6587

Closed

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Nov 29, 2021

Trivial change of removing dead code.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6587/head:pull/6587
$ git checkout pull/6587

Update a local copy of the PR:
$ git checkout pull/6587
$ git pull https://git.openjdk.java.net/jdk pull/6587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6587

View PR using the GUI difftool:
$ git pr show -t 6587

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6587.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 29, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 29, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm and trivial

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277904: G1: Remove G1CardSetArray::max_entries

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

  • e3e5908: 8277847: Support toolGuide tag in class-level documentation
  • 9a3a9b1: 8277865: G1: Change integer division to floating point division
  • aed53ee: 8264838: IGV: enhance graph export functionality
  • 0c7a4b8: 8277842: IGV: Add jvms property to know where a node came from
  • c3a7f2f: 8277382: make c1 BlockMerger use IR::verify only when necessary
  • 8f9eb62: 8274784: jshell: Garbled character was displayed by System.out.println(...) on Japanese Windows
  • e9b36a8: 8276670: G1: Rename G1CardSetFreePool and related classes
  • b9eb532: 8276685: Malformed Javadoc inline tags in JDK source in /jdk/management/jfr/RecordingInfo.java
  • 40fef23: 8275908: Record null_check traps for calls and array_check traps in the interpreter
  • 3d810ad: 8277411: C2 fast_unlock intrinsic on AArch64 has unnecessary ownership check
  • ... and 48 more: https://git.openjdk.java.net/jdk/compare/bb11c55dff86706a010c93ee2cc60c87bb2d53b6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 29, 2021
@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Nov 29, 2021

Thanks Thomas for your review.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

Going to push as commit 960bdde.
Since your change was applied there have been 63 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@Hamlin-Li Pushed as commit 960bdde.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the remove.xxx_entries.in.G1CardSetArray branch Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
2 participants