Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277924: Small tweaks to foreign function and memory API #6589

Closed
wants to merge 12 commits into from

Conversation

mcimadamore
Copy link
Contributor

@mcimadamore mcimadamore commented Nov 29, 2021

Following integration of the second incubator of the foreign function and memory API [1], we detected few divergences between the contents of the jdk repo and the panama repo:

  • the name of some of the FunctionDescriptor wither methods is different (e.g. withAppendedLayoutArguments vs. appendLayoutArguments), as it has been simplified and improved following a change that was not incorporated in [1].

  • TestUpcall does not execute all the test combinations, because of an issue in the jtreg header (also fixed in the panama repo)

  • Addressing some feedback, we would like to bring back alignment to JAVA_INT layout constants (and related constants).

Javadoc: http://cr.openjdk.java.net/~mcimadamore/8277924/v1/javadoc/jdk/incubator/foreign/package-summary.html
Specdiff: http://cr.openjdk.java.net/~mcimadamore/8277924/v1/spec_diff/overview-summary.html

[1] - #5907


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8277924: Small tweaks to foreign function and memory API
  • JDK-8277940: Small tweaks to foreign function and memory API (CSR) ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6589/head:pull/6589
$ git checkout pull/6589

Update a local copy of the PR:
$ git checkout pull/6589
$ git pull https://git.openjdk.java.net/jdk pull/6589/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6589

View PR using the GUI difftool:
$ git pr show -t 6589

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6589.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 29, 2021

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@mcimadamore The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Nov 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277924: Small tweaks to foreign function and memory API

Reviewed-by: jvernee, psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 29, 2021
@mcimadamore
Copy link
Contributor Author

@mcimadamore mcimadamore commented Nov 29, 2021

/csr

@openjdk openjdk bot added the csr label Nov 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@mcimadamore this pull request will not be integrated until the CSR request JDK-8277940 for issue JDK-8277924 has been approved.

@openjdk openjdk bot removed the ready label Nov 29, 2021
@mcimadamore mcimadamore marked this pull request as ready for review Nov 29, 2021
@openjdk openjdk bot added the rfr label Nov 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 29, 2021

Webrevs

…ValueLayout.java

Co-authored-by: Jorn Vernee <JornVernee@users.noreply.github.com>
@openjdk openjdk bot added ready and removed csr labels Nov 29, 2021
@mcimadamore
Copy link
Contributor Author

@mcimadamore mcimadamore commented Nov 30, 2021

@openjdk openjdk bot added csr and removed ready labels Nov 30, 2021
@openjdk openjdk bot added ready and removed csr labels Dec 2, 2021
@mcimadamore
Copy link
Contributor Author

@mcimadamore mcimadamore commented Dec 2, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2021

Going to push as commit ea905bd.

@openjdk openjdk bot closed this Dec 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2021

@mcimadamore Pushed as commit ea905bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
3 participants