Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254776: Remove unimplemented LowMemoryDetector::check_memory_usage #659

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 14, 2020

LowMemoryDetector::check_memory_usage seems declared but not implemented. Current history does not show any definitions since the initial load. Can be removed.

Testing:

  • Linux x86_64 build
  • Test search for check_memory_usage in src/hotspot

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) (1/2 failed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8254776: Remove unimplemented LowMemoryDetector::check_memory_usage

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/659/head:pull/659
$ git checkout pull/659

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 14, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 14, 2020

Webrevs

Loading

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Oct 14, 2020

/label serviceability

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@dcubed-ojdk
The serviceability label was successfully added.

Loading

@shipilev shipilev force-pushed the JDK-8254776-unimpl-low-memory-detector branch from e5395ec to 38460d4 Oct 19, 2020
Copy link
Contributor

@sspitsyn sspitsyn left a comment

This looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 19, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254776: Remove unimplemented LowMemoryDetector::check_memory_usage

Reviewed-by: sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 74ac77e: 8247666: Support Lambda proxy classes in static CDS archive
  • e2e11d3: 8254955: x86: MethodHandlesAdapterBlob is too big
  • 0b51016: 8253660: Need better error report when artifact resolution fails in AotCompiler.java
  • 52cb329: 8254862: lldb in devkit doesn't work
  • 60f63ec: 8254796: Cleanup pervasive unnecessary parameter
  • 953e472: 8254967: com.sun.net.HttpsServer spins on TLS session close
  • 1da28de: 8255009: delta apply fixes for JDK-8246774 and JDK-8253455, pushed too soon
  • a0382cd: 8253235: JFR.dump does not respect maxage parameter
  • cb7701b: 8253970: Build error: address argument to atomic builtin must be a pointer to integer or pointer ('volatile narrowOop *' invalid)
  • 4ffed32: 8254940: AArch64: Cleanup non-product thread members
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/51a865d66a5dddbbaaa4bb656fa02ecd1bee1a0b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 19, 2020
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 20, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 20, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2020

@shipilev Since your change was applied there have been 31 commits pushed to the master branch:

  • b65dcfa: 8197981: Missing return statement in __sync_val_compare_and_swap_8
  • 5b51085: 8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes
  • c87cdf7: 8254029: ObjectMonitor cleanup/minor bug-fix changes extracted from JDK-8253064
  • 7a580ca: 8255027: Problem list for Graal test gc/stress/TestStressG1Humongous.java
  • 6e8835c: 7110890: reg test TranslucentShapedFrameTest fails to create non-opaque frame
  • bf19581: 8255016: ConstantDescs.FALSE claims it represents TRUE
  • 0f4fb36: 8255032: Conflict between recent pushes breaks the build
  • cb5cdd7: 8254721: Improve support for conditionally generated files
  • 0001435: 8255020: Minor updates to docs jdk.incubator.vector
  • 14e1e17: 8255004: [JVMCI] expose JVM_ACC_FIELD_INITIALIZED_FINAL_UPDATE
  • ... and 21 more: https://git.openjdk.java.net/jdk/compare/51a865d66a5dddbbaaa4bb656fa02ecd1bee1a0b...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0a75b37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8254776-unimpl-low-memory-detector branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants