Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277944: JDK 18 - update GA Release Date #6596

Closed
wants to merge 1 commit into from
Closed

Conversation

pashh
Copy link
Contributor

@pashh pashh commented Nov 29, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6596/head:pull/6596
$ git checkout pull/6596

Update a local copy of the PR:
$ git checkout pull/6596
$ git pull https://git.openjdk.java.net/jdk pull/6596/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6596

View PR using the GUI difftool:
$ git pr show -t 6596

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6596.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 29, 2021

👋 Welcome back pashh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

⚠️ @pashh a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 3d39f09c6cdc875b44147b4e84e496b6abf93996
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@pashh The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build rfr labels Nov 29, 2021
@pashh
Copy link
Contributor Author

@pashh pashh commented Nov 29, 2021

/integrate

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 29, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@pashh This pull request has not yet been marked as ready for integration.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@pashh This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277944: JDK 18 - update GA Release Date

Reviewed-by: coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@pashh Unknown command itegrate - for a list of valid commands use /help.

@pashh
Copy link
Contributor Author

@pashh pashh commented Nov 29, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@pashh
Your change (at version 188c8b6) is now ready to be sponsored by a Committer.

@pashh
Copy link
Contributor Author

@pashh pashh commented Nov 29, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@pashh
Your change (at version 188c8b6) is now ready to be sponsored by a Committer.

@pashh
Copy link
Contributor Author

@pashh pashh commented Nov 29, 2021

/help

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@pashh Available commands:

  • cc - add or remove an additional classification label
  • clean - Mark the backport pull request as a clean backport
  • contributor - adds or removes additional contributors for a PR
  • covered - used when employer has signed the OCA
  • csr - require a compatibility and specification request (CSR) for this pull request
  • help - shows this text
  • integrate - performs integration of the changes in the PR
  • issue - edit the list of issues that this PR solves
  • label - add or remove an additional classification label
  • open - Set the pull request state to "open"
  • reviewer - manage additional reviewers for a PR
  • reviewers - set the number of additional required reviewers for this PR
  • signed - used after signing the OCA
  • solves - edit the list of issues that this PR solves
  • sponsor - performs integration of a PR that is authored by a non-committer
  • summary - updates the summary in the commit message
  • test - used to run tests

@coffeys
Copy link
Contributor

@coffeys coffeys commented Nov 29, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

Going to push as commit 825e633.

@openjdk openjdk bot closed this Nov 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@coffeys @pashh Pushed as commit 825e633.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
2 participants