8250563: Add KVHashtable::add_if_absent

[iklam]

Please review this XS change. I added a new KVHashtable::add_if_absent function (modeled after ResourceHashtable::put_if_absent from JDK-8244733).

• I used "add" instead of "put" to be consistent with the naming convention in utility/hashtable.hpp
• I also fixed a type in the comments in resourceHashtable.hpp

Running mach5 tiers1/2.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8250563: Add KVHashtable::add_if_absent

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/66/head:pull/66
$ git checkout pull/66

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following label will be automatically applied to this pull request: hotspot-runtime.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[mlbridge]

Webrevs

• 02: Full - Incremental (ca5000a)
• 01: Full - Incremental (5249b6b)
• 00: Full (f41faaad593ef1291dc1ee27f426a1ce272410b5)

[shipilev]

Otherwise looks good, modulo the single signature question in review.

[calvinccheung]

Looks good.

[openjdk]

@iklam This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8250563: Add KVHashtable::add_if_absent

Reviewed-by: ccheung, coleenp

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 10 commits pushed to the master branch:

• 91a20ca: 8252695: Shenandoah: clean up Graal enabled/disabled filter in tests
• 704f784: 8252871: fatal error: must own lock JvmtiThreadState_lock
• bf5da0c: 8252897: Minor .jcheck/conf update
• 7600274: 8252859: Inconsistent use of alpha in class AbsSeq
• 4fb1980: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
• 73ba3ae: 8252500: ZGC on aarch64: Unable to allocate heap for certain Linux kernel configurations
• 5dd1ead: 8252767: URLConnection.setRequestProperty throws IllegalAccessError
• 2cceeed: 8166554: Avoid compilation blocking in OverloadCompileQueueTest.java
• 188b0bc: 8252868: Clean up unused function from G1MMUTracker
• 891886b: 8252887: Zero VM is broken after JDK-8252661

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 91a20ca7e5dfd91a206966a589afabd1f732c6a9.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

/integrate

[openjdk]

@iklam Since your change was applied there have been 10 commits pushed to the master branch:

• 91a20ca: 8252695: Shenandoah: clean up Graal enabled/disabled filter in tests
• 704f784: 8252871: fatal error: must own lock JvmtiThreadState_lock
• bf5da0c: 8252897: Minor .jcheck/conf update
• 7600274: 8252859: Inconsistent use of alpha in class AbsSeq
• 4fb1980: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
• 73ba3ae: 8252500: ZGC on aarch64: Unable to allocate heap for certain Linux kernel configurations
• 5dd1ead: 8252767: URLConnection.setRequestProperty throws IllegalAccessError
• 2cceeed: 8166554: Avoid compilation blocking in OverloadCompileQueueTest.java
• 188b0bc: 8252868: Clean up unused function from G1MMUTracker
• 891886b: 8252887: Zero VM is broken after JDK-8252661

Your commit was automatically rebased without conflicts.

Pushed as commit 001e51d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.