Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277957: Add test group for IPv6 exclusive testing #6600

Closed

Conversation

frkator
Copy link
Member

@frkator frkator commented Nov 29, 2021

Adding test group for IPv6 exclusive testing.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277957: Add test group for IPv6 exclusive testing

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6600/head:pull/6600
$ git checkout pull/6600

Update a local copy of the PR:
$ git checkout pull/6600
$ git pull https://git.openjdk.java.net/jdk pull/6600/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6600

View PR using the GUI difftool:
$ git pr show -t 6600

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6600.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 29, 2021

👋 Welcome back isipka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@frkator The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Nov 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 29, 2021

Webrevs

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Nov 30, 2021

/label remove core-libs
/label add net

@openjdk openjdk bot removed the core-libs label Nov 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@AlanBateman
The core-libs label was successfully removed.

@openjdk openjdk bot added the net label Nov 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@AlanBateman
The net label was successfully added.

Copy link
Contributor

@AlanBateman AlanBateman left a comment

This looks okay to me.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 5, 2021

@frkator This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277957: Add test group for IPv6 exclusive testing

Reviewed-by: alanb, msheppar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 115 new commits pushed to the master branch:

  • 286a26c: 8278277: G1: Simplify implementation of G1GCPhaseTimes::record_or_add_time_secs
  • d14f06a: 8278031: MultiThreadedRefCounter should not use relaxed atomic decrement
  • 8d190dd: 8277496: Remove duplication in c1 Block successor lists
  • 194cdf4: 8277864: Compilation error thrown while doing a boxing conversion on selector expression
  • f39fe5b: 8154011: Make TraceDeoptimization a diagnostic flag
  • f180a45: 8278016: Add compiler tests to tier{2,3}
  • 104aa1f: 8268575: Annotations not visible on model elements before they are generated
  • 839b606: 8278143: Remove unused "argc" from ConstantPool::copy_bootstrap_arguments_at_impl
  • 267c024: 8265150: AsyncGetCallTrace crashes on ResourceMark
  • 9642629: 8276779: (ch) InputStream returned by Channels.newInputStream should have fast path for SelectableChannels
  • ... and 105 more: https://git.openjdk.java.net/jdk/compare/825e633e71ca942fe88c509e7f951ff8903c45cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @msheppar) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Dec 5, 2021
@@ -518,7 +518,21 @@ needs_g1gc = \
jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithG1FullCollection.java \
jdk/jfr/event/gc/objectcount/TestObjectCountAfterGCEventWithG1ConcurrentMark.java \
jdk/jfr/event/gc/heapsummary/TestHeapSummaryEventG1.java


Copy link

@msheppar msheppar Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment to indicate the purpose of this grouping i.e. as discussed earlier

This set of tests will be executed in an ipv6 only environment

dermotb
dermotb approved these changes Dec 6, 2021
@frkator
Copy link
Member Author

@frkator frkator commented Dec 6, 2021

/integrate

@openjdk openjdk bot added the sponsor label Dec 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

@frkator
Your change (at version e3e2409) is now ready to be sponsored by a Committer.

@msheppar
Copy link

@msheppar msheppar commented Dec 6, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

Going to push as commit 2ff1296.
Since your change was applied there have been 127 commits pushed to the master branch:

  • ea8d3c9: 8271566: DSA signature length value is not accurate in P11Signature
  • 239362d: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList
  • 2c31a17: 8275082: Update XML Security for Java to 2.3.0
  • 70bad89: 8277497: Last column cell in the JTAble row is read as empty cell
  • 5045eb5: 8278273: Remove unnecessary exclusion of doclint accessibility checks
  • 587e540: 8210558: serviceability/sa/TestJhsdbJstackLock.java fails to find '^\s+- waiting to lock <0x[0-9a-f]+> (a java.lang.Class ...'
  • 082fdf4: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • ab78187: 8277105: Inconsistent handling of missing permitted subclasses
  • adf3952: 8277372: Add getters for BOT and card table members
  • 7c6f57f: 8275610: C2: Object field load floats above its null check resulting in a segfault
  • ... and 117 more: https://git.openjdk.java.net/jdk/compare/825e633e71ca942fe88c509e7f951ff8903c45cf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Dec 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

@msheppar @frkator Pushed as commit 2ff1296.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated net
4 participants