Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277803: vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001 fails with "Synthetic fields not found" #6601

Closed
wants to merge 1 commit into from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Nov 29, 2021

This change fixes vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001 after JDK-8271623.

JDK-8271623 causes javac to omit a synthetic field from inner classes that do not reference their enclosing instance. The test was specifically checking for the presence of the synthetic field. To fix the test, this change adds an explicit reference to the enclosing instance of an inner class.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277803: vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001 fails with "Synthetic fields not found"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6601/head:pull/6601
$ git checkout pull/6601

Update a local copy of the PR:
$ git checkout pull/6601
$ git pull https://git.openjdk.java.net/jdk pull/6601/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6601

View PR using the GUI difftool:
$ git pr show -t 6601

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6601.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 29, 2021

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@cushon The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability label Nov 29, 2021
@openjdk openjdk bot added the rfr label Nov 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 29, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2021

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277803: vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001 fails with "Synthetic fields not found"

Reviewed-by: dholmes, cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 560f9c9: 8277426: Optimize mask reduction operations on x86
  • 3a4a94e: 8277854: The upper bound of GCCardSizeInBytes should be limited to 512 for 32-bit platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 29, 2021
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Hi Liam,
It looks good to me.
Thanks,
Serguei

@cushon
Copy link
Contributor Author

@cushon cushon commented Nov 30, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

Going to push as commit 27299ea.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 560f9c9: 8277426: Optimize mask reduction operations on x86
  • 3a4a94e: 8277854: The upper bound of GCCardSizeInBytes should be limited to 512 for 32-bit platforms

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@cushon Pushed as commit 27299ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated serviceability
4 participants