8277803: vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001 fails with "Synthetic fields not found"

[cushon]

This change fixes vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001 after JDK-8271623.

JDK-8271623 causes javac to omit a synthetic field from inner classes that do not reference their enclosing instance. The test was specifically checking for the presence of the synthetic field. To fix the test, this change adds an explicit reference to the enclosing instance of an inner class.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8277803: vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001 fails with "Synthetic fields not found"

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Chris Plummer (@plummercj - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6601/head:pull/6601
$ git checkout pull/6601

Update a local copy of the PR:
$ git checkout pull/6601
$ git pull https://git.openjdk.java.net/jdk pull/6601/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6601

View PR using the GUI difftool:
$ git pr show -t 6601

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6601.diff

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cushon The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9f45c6ce)

[dholmes-ora]

Looks good.

Thanks,
David

[openjdk]

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277803: vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001 fails with "Synthetic fields not found"

Reviewed-by: dholmes, cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 560f9c9: 8277426: Optimize mask reduction operations on x86
• 3a4a94e: 8277854: The upper bound of GCCardSizeInBytes should be limited to 512 for 32-bit platforms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sspitsyn]

Hi Liam,
It looks good to me.
Thanks,
Serguei

[cushon]

/integrate

[openjdk]

Going to push as commit 27299ea.
Since your change was applied there have been 2 commits pushed to the master branch:

• 560f9c9: 8277426: Optimize mask reduction operations on x86
• 3a4a94e: 8277854: The upper bound of GCCardSizeInBytes should be limited to 512 for 32-bit platforms

Your commit was automatically rebased without conflicts.

[openjdk]

@cushon Pushed as commit 27299ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.