Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277977: Incorrect references to --enable-reproducible-builds in docs #6609

Closed
wants to merge 1 commit into from

Conversation

mkartashev
Copy link
Member

@mkartashev mkartashev commented Nov 30, 2021

Corrects spelling mistakes in the documentation and one configure script message.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277977: Incorrect references to --enable-reproducible-builds in docs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6609/head:pull/6609
$ git checkout pull/6609

Update a local copy of the PR:
$ git checkout pull/6609
$ git pull https://git.openjdk.java.net/jdk pull/6609/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6609

View PR using the GUI difftool:
$ git pr show -t 6609

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6609.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 30, 2021

👋 Welcome back mkartashev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@mkartashev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Nov 30, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 30, 2021

Webrevs

Copy link
Member

@magicus magicus left a comment

Thanks for fixing these typos!

@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@mkartashev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277977: Incorrect references to --enable-reproducible-builds in docs

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 69f56a0: 8264485: build.tools.depend.Depend.toString(byte[]) creates malformed hex strings
  • fecf906: 8267928: Loop predicate gets inexact loop limit before PhaseIdealLoop::rc_predicate

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@magicus) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 30, 2021
@magicus
Copy link
Member

@magicus magicus commented Nov 30, 2021

@mkartashev I can sponsor this, once you have done /integrate.

@mkartashev
Copy link
Member Author

@mkartashev mkartashev commented Nov 30, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@mkartashev
Your change (at version d4b9f6b) is now ready to be sponsored by a Committer.

@magicus
Copy link
Member

@magicus magicus commented Nov 30, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

Going to push as commit 01cefc9.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 69f56a0: 8264485: build.tools.depend.Depend.toString(byte[]) creates malformed hex strings
  • fecf906: 8267928: Loop predicate gets inexact loop limit before PhaseIdealLoop::rc_predicate

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@magicus @mkartashev Pushed as commit 01cefc9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mkartashev
Copy link
Member Author

@mkartashev mkartashev commented Nov 30, 2021

@magicus Thanks for a quick review!

@mkartashev mkartashev deleted the JDK-8277977 branch Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
2 participants