Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277986: Typo in javadoc of #6615

wants to merge 1 commit into from


Copy link

@jaikiran jaikiran commented Nov 30, 2021

Can I please get a review for this change which fixes a typo in the javadoc of method?


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


  • JDK-8277986: Typo in javadoc of



Using git

Checkout this PR locally:
$ git fetch pull/6615/head:pull/6615
$ git checkout pull/6615

Update a local copy of the PR:
$ git checkout pull/6615
$ git pull pull/6615/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6615

View PR using the GUI difftool:
$ git pr show -t 6615

Using diff file

Download this PR as a diff file:

Copy link

@bridgekeeper bridgekeeper bot commented Nov 30, 2021

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 30, 2021
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@jaikiran The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Nov 30, 2021
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8277986: Typo in javadoc of

Reviewed-by: alanb, iris, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 98a9f03: 8277602: Deopt code does not extend the stack enough if the caller is an optimize entry blob

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 30, 2021
Copy link

@mlbridge mlbridge bot commented Nov 30, 2021


Copy link
Member Author

@jaikiran jaikiran commented Dec 1, 2021

Thank you everyone for the reviews.

Copy link
Member Author

@jaikiran jaikiran commented Dec 1, 2021


Copy link

@openjdk openjdk bot commented Dec 1, 2021

Going to push as commit 0a01baa.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 7049c13: 8231107: Allow store password to be null when saving a PKCS12 KeyStore
  • ab867f6: 8272162: S4U2Self ticket without forwardable flag
  • dd73e3c: 8277814: ConcurrentRefineThread should report rate when deactivating
  • 65251f7: 8151594: Move concurrent refinement thread activation logging out of GC pause
  • f1c20e9: 8190748: java/text/Format/DateFormat/ and NonGregorianFormatTest fail intermittently
  • 2942646: 8276683: Malformed Javadoc inline tags in JDK source in com/sun/tools/javac/util/
  • e30e676: 8277606: String(String) constructor could copy hashIsZero
  • 5a4a9bb: 8278019: ProblemList java/awt/dnd/BadSerializationTest/ on linux and windows
  • 15a6806: 8277434: tests fail with "assert(is_forwarded()) failed: only decode when actually forwarded"
  • 21d9ca6: 8274983: C1 optimizes the invocation of private interface methods
  • ... and 1 more:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 1, 2021
Copy link

@openjdk openjdk bot commented Dec 1, 2021

@jaikiran Pushed as commit 0a01baa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaikiran jaikiran deleted the 8277986 branch Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
core-libs integrated
4 participants