Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254780: EnterInterpOnlyModeClosure::completed() always returns true #662

Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 14, 2020

JDK-8238761 introduced this funky code:

class EnterInterpOnlyModeClosure : public HandshakeClosure {
 private:
  bool _completed;
 public:
  EnterInterpOnlyModeClosure() : HandshakeClosure("EnterInterpOnlyMode"), _completed(false) { }
  void do_thread(Thread* th) {
     ...
     _completed = true;
  }
  bool completed() {
    return _completed = true;
  }
};

It seems the flag is there to communicate that target thread indeed executed the handshake. But completed() sets the bool unconditionally and always returns true. And it is used in one and only place here:

     guarantee(hs.completed(), "Handshake failed: Target thread is not alive?");

...which means that guarantee always passes.

Attention @robehn :)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8254780: EnterInterpOnlyModeClosure::completed() always returns true

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/662/head:pull/662
$ git checkout pull/662

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 14, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@shipilev The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability hotspot labels Oct 14, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 14, 2020

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

It looks good.
Thank you for catching and fixing it!
Serguei

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254780: EnterInterpOnlyModeClosure::completed() always returns true

Reviewed-by: sspitsyn, rehn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 14, 2020
robehn
robehn approved these changes Oct 14, 2020
Copy link
Contributor

@robehn robehn left a comment

My bad, thanks @shipilev !

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 14, 2020

/integrate

@openjdk openjdk bot closed this Oct 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@shipilev Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit da2f5ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8254780-async-handshake-bool branch Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated serviceability
3 participants