Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8278014: [vectorapi] Remove test run script #6621

Conversation

PaulSandoz
Copy link
Member

@PaulSandoz PaulSandoz commented Nov 30, 2021

Remove Vector API scripts for building and running tests. jtreg should be used instead.

Also updated the test generation script to remove options that assume mercurial as the code repository.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6621/head:pull/6621
$ git checkout pull/6621

Update a local copy of the PR:
$ git checkout pull/6621
$ git pull https://git.openjdk.java.net/jdk pull/6621/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6621

View PR using the GUI difftool:
$ git pr show -t 6621

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6621.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 30, 2021

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@PaulSandoz To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@PaulSandoz
Copy link
Member Author

@PaulSandoz PaulSandoz commented Nov 30, 2021

/label add core-libs

@openjdk openjdk bot added the core-libs label Nov 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@PaulSandoz
The core-libs label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 30, 2021

Webrevs

Copy link

@sviswa7 sviswa7 left a comment

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2021

@PaulSandoz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278014: [vectorapi] Remove test run script

Reviewed-by: sviswanathan, jiefu, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 70d5dff: 8275326: C2: assert(no_dead_loop) failed: dead loop detected
  • 349328c: 8277777: [Vector API] assert(r->is_XMMRegister()) failed: must be in x86_32.ad
  • c733193: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException
  • da2be99: 8277026: Remove blank lines remaining from snippet markup
  • 0a01baa: 8277986: Typo in javadoc of java.util.zip.ZipEntry#setTime
  • 7049c13: 8231107: Allow store password to be null when saving a PKCS12 KeyStore
  • ab867f6: 8272162: S4U2Self ticket without forwardable flag
  • dd73e3c: 8277814: ConcurrentRefineThread should report rate when deactivating
  • 65251f7: 8151594: Move concurrent refinement thread activation logging out of GC pause
  • f1c20e9: 8190748: java/text/Format/DateFormat/DateFormatTest.java and NonGregorianFormatTest fail intermittently
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/98a9f037397d437d2c3221e8522ed8ab397a457a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 30, 2021
@DamonFool
Copy link
Member

@DamonFool DamonFool commented Nov 30, 2021

Shall we also update the copyright year?

@PaulSandoz
Copy link
Member Author

@PaulSandoz PaulSandoz commented Nov 30, 2021

Shall we also update the copyright year?

Doh! of course, updated.

Copy link
Member

@DamonFool DamonFool left a comment

Thanks for your update.
LGTM

@PaulSandoz
Copy link
Member Author

@PaulSandoz PaulSandoz commented Dec 1, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 1, 2021

Going to push as commit 9b3e672.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 1e9ed54: 8193682: Infinite loop in ZipOutputStream.close()
  • abaa073: 8277946: NMT: Deprecate and remove VM.native_memory shutdown jcmd command option
  • 37ff7f3: 8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size
  • 8d7958e: 8277981: String Deduplication table is never cleaned up due to bad dead_factor_for_cleanup
  • bc6dce1: 8277736: G1: Allow forced evacuation failure of first N regions in collection set
  • 0c29ee5: 8274319: Replace usages of Collections.sort with List.sort call in jdk.jfr
  • f505396: 8277459: Add jwebserver tool
  • 84aa0a1: 8278047: Few javax/imageio test regressed after JDK-8262297 fix
  • fde0b95: 8277861: Terminally deprecate Thread.stop
  • 70d5dff: 8275326: C2: assert(no_dead_loop) failed: dead loop detected
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/98a9f037397d437d2c3221e8522ed8ab397a457a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 1, 2021

@PaulSandoz Pushed as commit 9b3e672.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
4 participants