New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278016: Add compiler tests to tier{2,3} #6622
Conversation
|
Webrevs
|
/label hotspot-compiler |
@shipilev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 59 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
@shipilev again I think we need to examine this in terms of impact to our CI. We run different platforms and configurations in different tiers so the costs are not as simple as looking at one run. Thanks, |
Again, I can wait for those who have more insight in Oracle testing pipelines check their workflows with this change. I have no insight in Oracle infra, so somebody else have to do it. Now that Igor left, who should we be talking to? |
@dholmes-ora I checked and this change does not interfere with our CI. I also submitted our testing. I will let you know results. |
I don't see issues with these changes in my testing. I submitted our tier1,2,3 testing in internal infra. |
Vladimir, are internal infra results good? |
Yes, all passed. You can integrate. |
Thank you! /integrate |
Going to push as commit f180a45.
Your commit was automatically rebased without conflicts. |
I have been looking at
hotspot:tier4
(catch-all not in lower tiers) run logs, and realized the whole bunch of compiler tests are running there.Since
hotspot:tier4
runs a lot ofvmTestbase
tests, contributors seldom run it, as it takes many hours. Which means that many compiler tests are not running regularly for many contributors. But these tests are rather fast themselves and cover important compiler features.We can properly add compiler tests to
tier{2,3}
to expose them on earlier tiers. The split logic between tiers is roughly: fast feature tests go into tier2, slower feature tests and debugging/printing stuff goes to tier3.Sample times for new subgroups (think about this as "How much time they add to existing tiers"):
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6622/head:pull/6622
$ git checkout pull/6622
Update a local copy of the PR:
$ git checkout pull/6622
$ git pull https://git.openjdk.java.net/jdk pull/6622/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6622
View PR using the GUI difftool:
$ git pr show -t 6622
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6622.diff