Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278047: Few javax/imageio test regressed after JDK-8262297 fix #6631

Closed
wants to merge 1 commit into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Dec 1, 2021

Looks like we have 8 test cases where we are trying to write 15bpp BMP images and after JDK-8262297 all of them are failing.
We need to update these test cases to not encode 15bpp BMP images or supporting 15bpp BMP images is valid use case. This needs more investigation. I am backing out changes done under JDK-8262297 for further analysis.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278047: Few javax/imageio test regressed after JDK-8262297 fix

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6631/head:pull/6631
$ git checkout pull/6631

Update a local copy of the PR:
$ git checkout pull/6631
$ git pull https://git.openjdk.java.net/jdk pull/6631/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6631

View PR using the GUI difftool:
$ git pr show -t 6631

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6631.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 1, 2021

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 1, 2021
@openjdk
Copy link

openjdk bot commented Dec 1, 2021

@jayathirthrao The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 1, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 1, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm, is a clean backout. It would be nice to link the old changes directly for easier comparison in the PR text next time.

@openjdk
Copy link

openjdk bot commented Dec 1, 2021

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278047: Few javax/imageio test regressed after JDK-8262297 fix

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • fde0b95: 8277861: Terminally deprecate Thread.stop
  • 70d5dff: 8275326: C2: assert(no_dead_loop) failed: dead loop detected

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 1, 2021
@jayathirthrao
Copy link
Member Author

jayathirthrao commented Dec 1, 2021

Lgtm, is a clean backout. It would be nice to link the old changes directly for easier comparison in the PR text next time.

Thanks Thomas. Sure will do.

@jayathirthrao
Copy link
Member Author

jayathirthrao commented Dec 1, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2021

Going to push as commit 84aa0a1.
Since your change was applied there have been 2 commits pushed to the master branch:

  • fde0b95: 8277861: Terminally deprecate Thread.stop
  • 70d5dff: 8275326: C2: assert(no_dead_loop) failed: dead loop detected

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 1, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2021
@openjdk
Copy link

openjdk bot commented Dec 1, 2021

@jayathirthrao Pushed as commit 84aa0a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the JDK-8278047 branch Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants