8254788: Dead code in the sun.java2d.xr.XRPMBlitLoops$XrSwToPMBlit

[mrserb]

The XrSwToPMBlit is a blit which is used as a direct(unscaled) blit of the image in the memory to the pixmap. It tries to optimize the SrcOver composite in case of an opaque source image and use Src instead:

    if (CompositeType.SrcOverNoEa.equals(comp) && (src.getTransparency() == Transparency.OPAQUE)) {
        Blit opaqueSwToSurfaceBlit = Blit.getFromCache(src.getSurfaceType(), CompositeType.SrcNoEa, dst.getSurfaceType());
        opaqueSwToSurfaceBlit.Blit(src, dst, comp, clip, sx, sy, dx, dy, w, h);
    } else {

The code above does not work for two reasons:

• The check "CompositeType.SrcOverNoEa.equals(comp)" always fails because the comp is of type Composite(AlphaComposite/XORComposite/etc) not a CompositeType
• This optimisation is applied already in the sun.java2d.pipe.DrawImage#blitSurfaceData:
  https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/sun/java2d/pipe/DrawImage.java#L933

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8254788: Dead code in the sun.java2d.xr.XRPMBlitLoops$XrSwToPMBlit

Reviewers

• Phil Race (@prrace - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/665/head:pull/665
$ git checkout pull/665

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1f558b0)

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254788: Dead code in the sun.java2d.xr.XRPMBlitLoops$XrSwToPMBlit

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

• 294e070: 8254998: C2: assert(!n->as_Loop()->is_transformed_long_loop()) failure with -XX:StressLongCountedLoop=1
• 3ee0380: 8234393: [macos] printing ignores printer tray
• 3f9c8a3: 8254966: Remove unused code from Matcher
• 21e67e5: 8225790: Two NestedDialogs tests fail on Ubuntu
• 017d151: 8254842: [JVMCI] copy thread name when attaching libgraal thread to HotSpot
• 5d1397f: 8254282: Add Linux x86_32 builds to submit workflow
• 7ba6a6b: 8251158: Implementation of JEP 387: Elastic Metaspace
• 5fedfa7: 8251271: C2: Compile::_for_igvn list is corrupted after RenumberLiveNodes
• 98ec4a6: 8254805: compiler/debug/TestStressCM.java is still failing
• 355f44d: 8254994: [x86] C1 StubAssembler::call_RT, "call_offset might not be initialized"
• ... and 86 more: https://git.openjdk.java.net/jdk/compare/a09803737516cfc95fdba397f53af9ad0f88e1b8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

/integrate

[openjdk]

@mrserb Since your change was applied there have been 103 commits pushed to the master branch:

• 3267b09: 8254883: ZGC: Make the ZArrayIterator reusable for ZRelocationSetIterators
• cb6167b: 8254557: Compiler crashes with java.lang.AssertionError: isSubtype UNKNOWN
• 40f847e: 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents
• f167a71: 8254264: Remove redundant cross_modify_fence()
• 44f9271: 8254974: Fix stutter typo in TypeElement
• 76fdd7f: 8255038: Adjust adapter_code_size to account for -Xlog:methodhandles in debug builds
• cdc8c40: 8254878: Move last piece of ZArray to GrowableArray
• 294e070: 8254998: C2: assert(!n->as_Loop()->is_transformed_long_loop()) failure with -XX:StressLongCountedLoop=1
• 3ee0380: 8234393: [macos] printing ignores printer tray
• 3f9c8a3: 8254966: Remove unused code from Matcher
• ... and 93 more: https://git.openjdk.java.net/jdk/compare/a09803737516cfc95fdba397f53af9ad0f88e1b8...master

Your commit was automatically rebased without conflicts.

Pushed as commit 89e5444.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.