8268288: jdk/jfr/api/consumer/streaming/TestOutOfProcessMigration.java fails with "Error: ShouldNotReachHere()"

[calvinccheung]

A small fix to ensure that the globally shared ClassPathImageEntry is not being deleted in CDS code.
The test failure is hard to reproduce. The proposed fix passed CI tiers 1-4 testing.
Currently running the TestOutOfProcessMigration.java test repeatedly on linux-x64 with the vm options in the bug report.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268288: jdk/jfr/api/consumer/streaming/TestOutOfProcessMigration.java fails with "Error: ShouldNotReachHere()"

Reviewers

• Yumin Qi (@yminqi - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6651/head:pull/6651
$ git checkout pull/6651

Update a local copy of the PR:
$ git checkout pull/6651
$ git pull https://git.openjdk.java.net/jdk pull/6651/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6651

View PR using the GUI difftool:
$ git pr show -t 6651

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6651.diff

[calvinccheung]

/label add hotspot-runtime

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (03f9524a)

[yminqi]

Do you check if the file exists? If so please use os::file_exists which is better.

[calvinccheung]

Using os::file_exists won't work because few lines below that I need to use the st returned from os::stat.

ent = ClassLoader::create_class_path_entry(THREAD, path, &st, false, false);

[yminqi]

LGTM. Minor suggestion.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268288: jdk/jfr/api/consumer/streaming/TestOutOfProcessMigration.java fails with "Error: ShouldNotReachHere()"

Reviewed-by: minqi, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 201 new commits pushed to the master branch:

• 51d6d7a: 8266839: Enable pandoc on macosx-aarch64 at Oracle
• 0dfb3a7: 8268582: javadoc throws NPE with --ignore-source-errors option
• f41e768: 8277762: Allow configuration of HOTSPOT_BUILD_USER
• a363b7b: 8177819: DateTimeFormatterBuilder zone parsing should recognise DST
• 9b3e672: 8278014: [vectorapi] Remove test run script
• 1e9ed54: 8193682: Infinite loop in ZipOutputStream.close()
• abaa073: 8277946: NMT: Deprecate and remove VM.native_memory shutdown jcmd command option
• 37ff7f3: 8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size
• 8d7958e: 8277981: String Deduplication table is never cleaned up due to bad dead_factor_for_cleanup
• bc6dce1: 8277736: G1: Allow forced evacuation failure of first N regions in collection set
• ... and 191 more: https://git.openjdk.java.net/jdk/compare/d5e47d6b84514edde23a8baff8c2274e5b3ca6bb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

LGTM

[calvinccheung]

Thanks @iklam and @yminqi for the review.
/integrate

[openjdk]

Going to push as commit 0a09092.
Since your change was applied there have been 251 commits pushed to the master branch:

• 0d938ce: 8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux
• 0e7b6bc: 8278141: LIR_OpLoadKlass::_info shadows the field of the same name from LIR_Op
• 53a4342: 8278137: JFR: PrettyWriter uses incorrect year specifier
• f723779: 8278079: C2: expand_dtrace_alloc_probe doesn't take effect in macro.cpp
• 3f28a21: 8278144: Javadoc for MemorySegment::set/MemorySegment::setAtIndex is missing throws tag
• ba2a8e5: 8278205: jlink plugins should dump .class file in debug mode
• 18c54b4: 8274640: Cleanup unnecessary null comparison before instanceof check in java.desktop
• dda8f26: 8278139: G1: Refactor G1BlockOffsetTablePart::block_at_or_preceding
• e4774e6: 8277916: Gather non-strong reference count logic in a single place
• 53df9ff: 8278154: SimpleFileServer#createFileServer() should specify that the returned server is not started
• ... and 241 more: https://git.openjdk.java.net/jdk/compare/d5e47d6b84514edde23a8baff8c2274e5b3ca6bb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 0a09092.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.