-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278099: two sun/security/pkcs11/Signature tests failed with AssertionError #6656
Conversation
👋 Welcome back valeriep! A progress list of the required criteria for merging this PR into |
@valeriepeng The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Not a PKCS11 expert, but does a "digest-specific PSS signature mechanism" needs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a PKCS11 expert, but the fix does what @valeriepeng describes
in the bug report: removes the offending assert.
Thumbs up.
@valeriepeng This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Have you verified that this fix works on an Oracle_Linux_8.4 test machine? |
And I agree that this is a trivial fix. |
Previously when PSS support is added, the NSS library that we have does not support digest-specific PSS signatures. Now that some machine starts failing due to this assert and passes without this assert, it at least confirms that these digest-specific PSS signature mechanisms still work with the setParameter() call. I will take a closer look at these new mechanisms and see if any changes are needed. Best to remove this assert ASAP for a clean tier 2 result... |
/integrate |
Going to push as commit 669c90e.
Your commit was automatically rebased without conflicts. |
@valeriepeng Pushed as commit 669c90e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Can someone help reviewing this trivial one-line fix? The assert check in CK_MECHANISM.java is too strict and fail unexpectedly when digest-specific PSS signature mechanisms are supported by the underlying PKCS#11 library. The fix is to remove this assert check. No new regression test added with this fix as this is already covered by existing regression tests.
Thanks,
Valerie
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6656/head:pull/6656
$ git checkout pull/6656
Update a local copy of the PR:
$ git checkout pull/6656
$ git pull https://git.openjdk.java.net/jdk pull/6656/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6656
View PR using the GUI difftool:
$ git pr show -t 6656
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6656.diff