Skip to content

JDK-8257856: Make ClassFileVersionsTest.java robust to JDK version updates #6657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

JDK-8257856: Make ClassFileVersionsTest.java robust to JDK version updates #6657

wants to merge 2 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Dec 2, 2021 •
edited by openjdk bot
Loading

Change the test in question to generate its data programmatically to avoid updates with each JDK release. (Assuming this gets pushed before the start of JDK 19, I'll revert the customary changes to the test in set of start-of-19 updates.)

Running the test, it does probe the same set of values:

STDOUT:
test ClassFileVersionsTest.testSupported(53, 0, []): success
test ClassFileVersionsTest.testSupported(53, 0, [STATIC]): success
test ClassFileVersionsTest.testSupported(53, 0, [TRANSITIVE]): success
test ClassFileVersionsTest.testSupported(53, 0, [TRANSITIVE, STATIC]): success
test ClassFileVersionsTest.testSupported(54, 0, []): success
test ClassFileVersionsTest.testSupported(55, 0, []): success
test ClassFileVersionsTest.testSupported(56, 0, []): success
test ClassFileVersionsTest.testSupported(57, 0, []): success
test ClassFileVersionsTest.testSupported(58, 0, []): success
test ClassFileVersionsTest.testSupported(59, 0, []): success
test ClassFileVersionsTest.testSupported(60, 0, []): success
test ClassFileVersionsTest.testSupported(61, 0, []): success
test ClassFileVersionsTest.testSupported(62, 0, []): success

test ClassFileVersionsTest.testUnsupported(50, 0, []): success
test ClassFileVersionsTest.testUnsupported(51, 0, []): success
test ClassFileVersionsTest.testUnsupported(52, 0, []): success
test ClassFileVersionsTest.testUnsupported(54, 0, [STATIC]): success
test ClassFileVersionsTest.testUnsupported(54, 0, [TRANSITIVE]): success
test ClassFileVersionsTest.testUnsupported(54, 0, [TRANSITIVE, STATIC]): success
test ClassFileVersionsTest.testUnsupported(55, 0, [STATIC]): success
test ClassFileVersionsTest.testUnsupported(55, 0, [TRANSITIVE]): success
test ClassFileVersionsTest.testUnsupported(55, 0, [TRANSITIVE, STATIC]): success
test ClassFileVersionsTest.testUnsupported(56, 0, [STATIC]): success
test ClassFileVersionsTest.testUnsupported(56, 0, [TRANSITIVE]): success
test ClassFileVersionsTest.testUnsupported(56, 0, [TRANSITIVE, STATIC]): success
test ClassFileVersionsTest.testUnsupported(57, 0, [STATIC]): success
test ClassFileVersionsTest.testUnsupported(57, 0, [TRANSITIVE]): success
test ClassFileVersionsTest.testUnsupported(57, 0, [TRANSITIVE, STATIC]): success
test ClassFileVersionsTest.testUnsupported(58, 0, [STATIC]): success
test ClassFileVersionsTest.testUnsupported(58, 0, [TRANSITIVE]): success
test ClassFileVersionsTest.testUnsupported(58, 0, [TRANSITIVE, STATIC]): success
test ClassFileVersionsTest.testUnsupported(59, 0, [STATIC]): success
test ClassFileVersionsTest.testUnsupported(59, 0, [TRANSITIVE]): success
test ClassFileVersionsTest.testUnsupported(59, 0, [TRANSITIVE, STATIC]): success
test ClassFileVersionsTest.testUnsupported(60, 0, [STATIC]): success
test ClassFileVersionsTest.testUnsupported(60, 0, [TRANSITIVE]): success
test ClassFileVersionsTest.testUnsupported(60, 0, [TRANSITIVE, STATIC]): success
test ClassFileVersionsTest.testUnsupported(61, 0, [STATIC]): success
test ClassFileVersionsTest.testUnsupported(61, 0, [TRANSITIVE]): success
test ClassFileVersionsTest.testUnsupported(61, 0, [TRANSITIVE, STATIC]): success
test ClassFileVersionsTest.testUnsupported(62, 0, [STATIC]): success
test ClassFileVersionsTest.testUnsupported(62, 0, [TRANSITIVE]): success
test ClassFileVersionsTest.testUnsupported(62, 0, [TRANSITIVE, STATIC]): success
test ClassFileVersionsTest.testUnsupported(63, 0, []): success

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257856: Make ClassFileVersionsTest.java robust to JDK version updates

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6657/head:pull/6657
$ git checkout pull/6657

Update a local copy of the PR:
$ git checkout pull/6657
$ git pull https://git.openjdk.java.net/jdk pull/6657/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6657

View PR using the GUI difftool:
$ git pr show -t 6657

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6657.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 2, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 2, 2021

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 2, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 2, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 2, 2021

Webrevs

AlanBateman
AlanBateman approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, saves work at each release.

@openjdk
Copy link

openjdk bot commented Dec 2, 2021 •
edited
Loading

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257856: Make ClassFileVersionsTest.java robust to JDK version updates

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • ad1ff27: 8277422: tools/jar/JarEntryTime.java fails with modified time mismatch
  • 7c4ef3a: 8277985: G1: Compare max_parallel_refinement_threads to UINT_MAX
  • dc2abc9: 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation
  • 8d9cb2e: 8278078: Cannot reference super before supertype constructor has been called
  • 65960f7: 8277753: Long*VectorTests.java fail with "bad AD file" on x86_32 after JDK-8276162
  • 3889af3: 8277906: Incorrect type for IV phi of long counted loops after CCP
  • d2b16c8: 8276126: Dump time class transformation causes heap objects of non-boot classes to be archived
  • 7696897: 8276837: [macos]: Error when signing the additional launcher
  • 3d98ec1: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions
  • b79554b: 8278130: Failure in jdk/javadoc/tool/CheckManPageOptions.java after JDK-8274639
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/51d6d7a36b760b2b2b77269cc06438108a9931a2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 2, 2021
@jddarcy
Copy link
Member Author

jddarcy commented Dec 2, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 2, 2021

Going to push as commit 8b042d1.
Since your change was applied there have been 21 commits pushed to the master branch:

  • ad1ff27: 8277422: tools/jar/JarEntryTime.java fails with modified time mismatch
  • 7c4ef3a: 8277985: G1: Compare max_parallel_refinement_threads to UINT_MAX
  • dc2abc9: 8278080: Add --with-cacerts-src='user cacerts folder' to enable deterministic cacerts generation
  • 8d9cb2e: 8278078: Cannot reference super before supertype constructor has been called
  • 65960f7: 8277753: Long*VectorTests.java fail with "bad AD file" on x86_32 after JDK-8276162
  • 3889af3: 8277906: Incorrect type for IV phi of long counted loops after CCP
  • d2b16c8: 8276126: Dump time class transformation causes heap objects of non-boot classes to be archived
  • 7696897: 8276837: [macos]: Error when signing the additional launcher
  • 3d98ec1: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions
  • b79554b: 8278130: Failure in jdk/javadoc/tool/CheckManPageOptions.java after JDK-8274639
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/51d6d7a36b760b2b2b77269cc06438108a9931a2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 2, 2021
@openjdk
Copy link

openjdk bot commented Dec 2, 2021

@jddarcy Pushed as commit 8b042d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8257856 branch December 9, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanBateman AlanBateman AlanBateman approved these changes

Assignees
No one assigned
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jddarcy @AlanBateman