Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx #6659

Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Dec 2, 2021

Spotted by Andrey here:
#6574 (comment)

Seems to be that way all the way back to JDK-8177968. Should be -Xms, like other GCLocker tests.

Additional testing:

  • Affected test still passes on Linux x86_64 fastdebug

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6659/head:pull/6659
$ git checkout pull/6659

Update a local copy of the PR:
$ git checkout pull/6659
$ git pull https://git.openjdk.java.net/jdk pull/6659/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6659

View PR using the GUI difftool:
$ git pr show -t 6659

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6659.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 2, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2021

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Dec 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 2, 2021

Webrevs

Copy link

@Hamlin-Li Hamlin-Li left a comment

Lgtm.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx

Reviewed-by: mli, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 3d98ec1: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions
  • b79554b: 8278130: Failure in jdk/javadoc/tool/CheckManPageOptions.java after JDK-8274639
  • ea905bd: 8277924: Small tweaks to foreign function and memory API
  • e002bfe: 8278049: G1: add precondition to set_remainder_to_point_to_start
  • 16cfbc4: 8278071: typos in MemorySegment::set, MemorySegment::setAtIndex javadoc
  • 84ca14d: 8277194: applications/runthese/RunThese30M.java crashes with jfrSymbolTable.cpp:305 assert(_instance != null)
  • 103da8f: 8274639: Provide a way to disable warnings for cross-modular links
  • 088b244: 8251216: Implement MD5 intrinsics on AArch64
  • a093cdd: 8276657: XSLT compiler tries to define a class with empty name
  • 8198807: 8266435: WBMPImageReader.read() should not truncate the input stream
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/fde0b95ede68c188479852c46df7e28dc4b79594...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 2, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Dec 2, 2021

Trivial, right?

@Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Dec 3, 2021

Yes, trivial.

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Dec 3, 2021

Thanks!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2021

Going to push as commit 0fbd271.
Since your change was applied there have been 49 commits pushed to the master branch:

  • bef5c7a: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
  • 473ecec: 8278174: runtime/cds/appcds/LambdaWithJavaAgent.java fails with release VMs
  • 19ce33d: 8258512: serviceability/sa/TestJmapCore.java timed out on macOS 10.13.6
  • c93552c: 8277069: [REDO] JDK-8276743 Make openjdk build Zip Archive generation "reproducible"
  • b8ac0d2: 8276681: Additional malformed Javadoc inline tags in JDK source
  • b310f30: 8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread
  • 15345e3: 8276661: (fs) UserDefinedFileAttributeView no longer works with long path (win)
  • 652b5f8: 8276674: Malformed Javadoc inline tags in JDK source
  • e0f1fc7: 8277358: Accelerate CRC32-C
  • 73a9654: 8276806: Use Objects.checkFromIndexSize where possible in java.base
  • ... and 39 more: https://git.openjdk.java.net/jdk/compare/fde0b95ede68c188479852c46df7e28dc4b79594...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2021

@shipilev Pushed as commit 0fbd271.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8278115-serial-gclocker-test branch Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants