-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278119: ProblemList few headful test failing in macosx12-aarch64 system #6663
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label add client |
@prsadhuk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
javax/swing/JTree/4908142/bug4908142.java has
also shown up in some of the sightings on these
machines. You should add that one also.
java/awt/GraphicsDevice/CheckDisplayModes.java has also been
showing up recently, but it has a different failure "exit code 133".
I don't know if you want to include that one.
So there are 8 pretty much solid failures and 2 others that also
show up, but not in every run.
javax/swing/JTree/4908142/bug4908142.java I have a separate review going on for that #6661 has different issue and not color related.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarifications!
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 206 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 660f21a.
Your commit was automatically rebased without conflicts. |
Few tests are failing on macos12-aarch64 systems due to mismatch in color value obtained from robot.getPixelColor and expected color.
More details on the failures can be seen in JDK-8277816. Till the root cause is investigated, it is better to problemlist it as it causing failures in CI run.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6663/head:pull/6663
$ git checkout pull/6663
Update a local copy of the PR:
$ git checkout pull/6663
$ git pull https://git.openjdk.java.net/jdk pull/6663/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6663
View PR using the GUI difftool:
$ git pr show -t 6663
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6663.diff