8278154: SimpleFileServer#createFileServer() should specify that the returned server is not started

[FrauBoes]

This doc-only change amends the method-level documentation of SimpleFileServer#createFileServer() to specify the state of the returned server.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed
• Change requires a CSR request to be approved

Issues

• JDK-8278154: SimpleFileServer#createFileServer() should specify that the returned server is not started
• JDK-8278159: SimpleFileServer#createFileServer() should specify that the returned server is not started (CSR)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6674/head:pull/6674
$ git checkout pull/6674

Update a local copy of the PR:
$ git checkout pull/6674
$ git pull https://git.openjdk.java.net/jdk pull/6674/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6674

View PR using the GUI difftool:
$ git pr show -t 6674

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6674.diff

[bridgekeeper]

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[FrauBoes]

/csr needed

[openjdk]

@FrauBoes has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@FrauBoes please create a CSR request for issue JDK-8278154. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@FrauBoes The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2a93771b)

[jaikiran]

Hello Julia,
Thank you for this quick change. I'm not a Reviewer, but this looks good to me.

[FrauBoes]

CSR: https://bugs.openjdk.java.net/browse/JDK-8278159

[FrauBoes]

/integrate

[openjdk]

@FrauBoes This pull request has not yet been marked as ready for integration.

[openjdk]

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278154: SimpleFileServer#createFileServer() should specify that the returned server is not started

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• d1cad24: 8278168: Add a few missing words to the specification of Files.mismatch
• 45da3ae: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup
• 8907003: 8272234: Pass originating elements from Filer to JavaFileManager
• 0fbd271: 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx
• bef5c7a: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
• 473ecec: 8278174: runtime/cds/appcds/LambdaWithJavaAgent.java fails with release VMs
• 19ce33d: 8258512: serviceability/sa/TestJmapCore.java timed out on macOS 10.13.6
• c93552c: 8277069: [REDO] JDK-8276743 Make openjdk build Zip Archive generation "reproducible"
• b8ac0d2: 8276681: Additional malformed Javadoc inline tags in JDK source
• b310f30: 8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread
• ... and 15 more: https://git.openjdk.java.net/jdk/compare/d2b16c89855d584a563caa4f725802dc91a83407...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[FrauBoes]

/integrate

[openjdk]

Going to push as commit 53df9ff.
Since your change was applied there have been 25 commits pushed to the master branch:

• d1cad24: 8278168: Add a few missing words to the specification of Files.mismatch
• 45da3ae: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup
• 8907003: 8272234: Pass originating elements from Filer to JavaFileManager
• 0fbd271: 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx
• bef5c7a: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
• 473ecec: 8278174: runtime/cds/appcds/LambdaWithJavaAgent.java fails with release VMs
• 19ce33d: 8258512: serviceability/sa/TestJmapCore.java timed out on macOS 10.13.6
• c93552c: 8277069: [REDO] JDK-8276743 Make openjdk build Zip Archive generation "reproducible"
• b8ac0d2: 8276681: Additional malformed Javadoc inline tags in JDK source
• b310f30: 8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread
• ... and 15 more: https://git.openjdk.java.net/jdk/compare/d2b16c89855d584a563caa4f725802dc91a83407...master

Your commit was automatically rebased without conflicts.

[openjdk]

@FrauBoes Pushed as commit 53df9ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.