Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8254795: Remove obsolete template files #668

Conversation

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Oct 14, 2020

Not so much a "blast from the past" but a whiff of an odor.

Memories of an earlier time long ago, whose time is past.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/668/head:pull/668
$ git checkout pull/668

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 14, 2020

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc label Oct 14, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 14, 2020

Webrevs

Copy link
Member

@kusrinivasan kusrinivasan left a comment

Wonder how this got by, anyway good riddance.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254795: Remove obsolete template files

Reviewed-by: ksrini

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

  • 96bb6e7: 8251325: Miss 'L' for long value in if statement
  • 546620b: 8254192: ExtraSharedClassListFile contains extra white space at end of line
  • f3ce45f: 8254799: runtime/ErrorHandling/TestHeapDumpOnOutOfMemoryError.java fails with release VMs
  • cda22e3: 8254811: JDK-8254158 broke ppc64, s390 builds
  • 8ef88e5: 8249878: jfr_emergency_dump has secondary crashes
  • 3c2f5e0: 8254674: G1: Improve root location reference to dead obj verification message
  • abe5137: 8254719: ZGC: Clean up includes
  • 60159cf: 8253952: Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's compressed size
  • 9359ff0: 8252221: Use multiple workers for Parallel GC pre-touching
  • f44fc6d: 8254734: "dead loop detected" assert failure with patch from 8223051
  • ... and 33 more: https://git.openjdk.java.net/jdk/compare/3fb2e822be11a8fdfa708f88b7dcf7a5066a2335...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 16, 2020
@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented Oct 16, 2020

/integrate

@openjdk openjdk bot closed this Oct 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2020

@jonathan-gibbons Since your change was applied there have been 51 commits pushed to the master branch:

  • 07ec35e: 8254623: gc/g1/TestHumongousConcurrentStartUndo.java still fails sometimes
  • 0570cc1: 8254855: Clean up and remove unused code in vmIntrinsics
  • 1742c44: 8254695: G1: Next mark bitmap clear not cancelled after marking abort
  • 34583eb: 8254161: Prevent instantiation of EnumSet subclasses through deserialization
  • 3d23bd8: 8254814: [Vector API] Fix an AVX512 crash after JDK-8223347
  • 7c0d417: 8251535: Partial peeling at unsigned test adds incorrect loop exit check
  • 5145bed: 8254125: Assertion in cppVtables.cpp during builds on 32bit Windows
  • bdda205: 8254369: Node::disconnect_inputs may skip precedences
  • 96bb6e7: 8251325: Miss 'L' for long value in if statement
  • 546620b: 8254192: ExtraSharedClassListFile contains extra white space at end of line
  • ... and 41 more: https://git.openjdk.java.net/jdk/compare/3fb2e822be11a8fdfa708f88b7dcf7a5066a2335...master

Your commit was automatically rebased without conflicts.

Pushed as commit 402d01a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the jonathan-gibbons:8254795-template-files branch Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants