Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux #6681

Closed
wants to merge 1 commit into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Dec 2, 2021

Please review this simple change which merely adds @requires (os.family == "linux") to the test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6681/head:pull/6681
$ git checkout pull/6681

Update a local copy of the PR:
$ git checkout pull/6681
$ git pull https://git.openjdk.java.net/jdk pull/6681/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6681

View PR using the GUI difftool:
$ git pr show -t 6681

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6681.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 2, 2021

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 2, 2021
@openjdk
Copy link

openjdk bot commented Dec 2, 2021

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Dec 2, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 2, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 2, 2021

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux

Reviewed-by: lancea, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • 0fbd271: 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx
  • bef5c7a: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
  • 473ecec: 8278174: runtime/cds/appcds/LambdaWithJavaAgent.java fails with release VMs
  • 19ce33d: 8258512: serviceability/sa/TestJmapCore.java timed out on macOS 10.13.6
  • c93552c: 8277069: [REDO] JDK-8276743 Make openjdk build Zip Archive generation "reproducible"
  • b8ac0d2: 8276681: Additional malformed Javadoc inline tags in JDK source
  • b310f30: 8277396: [TESTBUG] In DefaultButtonModelCrashTest.java, frame is accessed from main thread
  • 15345e3: 8276661: (fs) UserDefinedFileAttributeView no longer works with long path (win)
  • 652b5f8: 8276674: Malformed Javadoc inline tags in JDK source
  • e0f1fc7: 8277358: Accelerate CRC32-C
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/51d6d7a36b760b2b2b77269cc06438108a9931a2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 2, 2021
@bplb
Copy link
Member Author

bplb commented Dec 3, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 3, 2021

Going to push as commit 0d938ce.
Since your change was applied there have been 49 commits pushed to the master branch:

  • 0e7b6bc: 8278141: LIR_OpLoadKlass::_info shadows the field of the same name from LIR_Op
  • 53a4342: 8278137: JFR: PrettyWriter uses incorrect year specifier
  • f723779: 8278079: C2: expand_dtrace_alloc_probe doesn't take effect in macro.cpp
  • 3f28a21: 8278144: Javadoc for MemorySegment::set/MemorySegment::setAtIndex is missing throws tag
  • ba2a8e5: 8278205: jlink plugins should dump .class file in debug mode
  • 18c54b4: 8274640: Cleanup unnecessary null comparison before instanceof check in java.desktop
  • dda8f26: 8278139: G1: Refactor G1BlockOffsetTablePart::block_at_or_preceding
  • e4774e6: 8277916: Gather non-strong reference count logic in a single place
  • 53df9ff: 8278154: SimpleFileServer#createFileServer() should specify that the returned server is not started
  • d1cad24: 8278168: Add a few missing words to the specification of Files.mismatch
  • ... and 39 more: https://git.openjdk.java.net/jdk/compare/51d6d7a36b760b2b2b77269cc06438108a9931a2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 3, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 3, 2021
@openjdk
Copy link

openjdk bot commented Dec 3, 2021

@bplb Pushed as commit 0d938ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the BlockDeviceSize-8278172 branch December 3, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants