8210558: serviceability/sa/TestJhsdbJstackLock.java fails to find '^\s+- waiting to lock <0x[0-9a-f]+> \(a java\.lang\.Class ...'

[plummercj]

The issue appears to be due to running jstack before allowing the 4 threads created by LingeredAppWithLock to fully start up and reach their blocking or timed wait state. With this fix LingeredAppWithLock.main() now waits until the threads have reached the blocking or timed wait state before calling into LingeredApp.main().

Tests that use LingeredAppWithLock call LingeredApp.startApp(), which will first launch LingeredAppWithLock and then block until the lock file is touched. This blocking/waiting is done the call to waitAppReady(), which will be called before LingeredApp.startApp() returns. The lock file is not touched until LingeredApp.main() is called, and it is not called until after LingeredAppWithBloc.main() has already verified the state of all the threads. Thus by the time LingeredApp.startApp() returns, we can be sure that the threads started by LingeredAppWithLock.main() are in the desired state.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8210558: serviceability/sa/TestJhsdbJstackLock.java fails to find '^\s+- waiting to lock <0x[0-9a-f]+> (a java.lang.Class ...'

Reviewers

• Kevin Walls (@kevinjwalls - Committer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6689/head:pull/6689
$ git checkout pull/6689

Update a local copy of the PR:
$ git checkout pull/6689
$ git pull https://git.openjdk.java.net/jdk pull/6689/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6689

View PR using the GUI difftool:
$ git pr show -t 6689

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6689.diff

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5dccbdab)

[plummercj]

I got some test failures when doing a large number of test runs. Need to investigate. Withdrawing for now.

[plummercj]

These test failures I am occasionally seeing also occur without my changes and appear to be due to OSX host issues, so I'm reopening this PR.

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8210558: serviceability/sa/TestJhsdbJstackLock.java fails to find '^\s+- waiting to lock <0x[0-9a-f]+> \(a java\.lang\.Class ...'

Reviewed-by: kevinw, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

• d14f06a: 8278031: MultiThreadedRefCounter should not use relaxed atomic decrement
• 8d190dd: 8277496: Remove duplication in c1 Block successor lists
• 194cdf4: 8277864: Compilation error thrown while doing a boxing conversion on selector expression
• f39fe5b: 8154011: Make TraceDeoptimization a diagnostic flag
• f180a45: 8278016: Add compiler tests to tier{2,3}
• 104aa1f: 8268575: Annotations not visible on model elements before they are generated
• 839b606: 8278143: Remove unused "argc" from ConstantPool::copy_bootstrap_arguments_at_impl
• 267c024: 8265150: AsyncGetCallTrace crashes on ResourceMark
• 9642629: 8276779: (ch) InputStream returned by Channels.newInputStream should have fast path for SelectableChannels
• 02ee337: 8278175: Enable all doclint warnings for build of java.desktop
• ... and 41 more: https://git.openjdk.java.net/jdk/compare/ad1ff27b730773a141d73744e5f5a899bdfbea78...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

Thanks for the reviews Serguei and Kevin!

[plummercj]

/integrate

[openjdk]

Going to push as commit 587e540.
Since your change was applied there have been 58 commits pushed to the master branch:

• 082fdf4: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
• ab78187: 8277105: Inconsistent handling of missing permitted subclasses
• adf3952: 8277372: Add getters for BOT and card table members
• 7c6f57f: 8275610: C2: Object field load floats above its null check resulting in a segfault
• a885aab: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
• 6994d80: 8278291: compiler/uncommontrap/TraceDeoptimizationNoRealloc.java fails with release VMs after JDK-8154011
• 286a26c: 8278277: G1: Simplify implementation of G1GCPhaseTimes::record_or_add_time_secs
• d14f06a: 8278031: MultiThreadedRefCounter should not use relaxed atomic decrement
• 8d190dd: 8277496: Remove duplication in c1 Block successor lists
• 194cdf4: 8277864: Compilation error thrown while doing a boxing conversion on selector expression
• ... and 48 more: https://git.openjdk.java.net/jdk/compare/ad1ff27b730773a141d73744e5f5a899bdfbea78...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit 587e540.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.