8277864: Compilation error thrown while doing a boxing conversion on selector expression

[lahodaj]

Consider a switch whose selector type is a primitive type (e.g. an integer). This may still be a pattern matching switch, if it has a case with a pattern label. But, as the selector type is primitive, TransPatterns must not attempt to generate a null check, so this patch avoids it.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8277864: Compilation error thrown while doing a boxing conversion on selector expression

Reviewers

• Jim Laskey (@JimLaskey - Reviewer)
• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6695/head:pull/6695
$ git checkout pull/6695

Update a local copy of the PR:
$ git checkout pull/6695
$ git pull https://git.openjdk.java.net/jdk pull/6695/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6695

View PR using the GUI difftool:
$ git pr show -t 6695

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6695.diff

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (aaef2cec)

[JimLaskey]

LGTM

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277864: Compilation error thrown while doing a boxing conversion on selector expression

Reviewed-by: jlaskey, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 120 new commits pushed to the master branch:

• 678ac58: 8278240: ProblemList containers/docker/TestJcmd.java on linux-aarch64
• 01cb2b9: 8277529: SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint
• 660f21a: 8278119: ProblemList few headful test failing in macosx12-aarch64 system
• 2e30fa9: 8278171: [vectorapi] Mask incorrectly computed for zero extending cast
• fbf096e: 8251400: Fix incorrect addition of library to test in JDK-8237858
• 0a09092: 8268288: jdk/jfr/api/consumer/streaming/TestOutOfProcessMigration.java fails with "Error: ShouldNotReachHere()"
• 0d938ce: 8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux
• 0e7b6bc: 8278141: LIR_OpLoadKlass::_info shadows the field of the same name from LIR_Op
• 53a4342: 8278137: JFR: PrettyWriter uses incorrect year specifier
• f723779: 8278079: C2: expand_dtrace_alloc_probe doesn't take effect in macro.cpp
• ... and 110 more: https://git.openjdk.java.net/jdk/compare/040b2c52d3e82048630fbd45a7db48a5e65204b7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vicente-romero-oracle]

looks good

[lahodaj]

/integrate

[openjdk]

Going to push as commit 194cdf4.
Since your change was applied there have been 133 commits pushed to the master branch:

• f39fe5b: 8154011: Make TraceDeoptimization a diagnostic flag
• f180a45: 8278016: Add compiler tests to tier{2,3}
• 104aa1f: 8268575: Annotations not visible on model elements before they are generated
• 839b606: 8278143: Remove unused "argc" from ConstantPool::copy_bootstrap_arguments_at_impl
• 267c024: 8265150: AsyncGetCallTrace crashes on ResourceMark
• 9642629: 8276779: (ch) InputStream returned by Channels.newInputStream should have fast path for SelectableChannels
• 02ee337: 8278175: Enable all doclint warnings for build of java.desktop
• 24e16ac: 8277617: Adjust AVX3Threshold for copy/fill stubs
• 2b87c2b: 8277793: Support vector F2I and D2L cast operations for X86
• e1cde19: 8278247: KeyStoreSpi::engineGetAttributes does not throws KeyStoreException
• ... and 123 more: https://git.openjdk.java.net/jdk/compare/040b2c52d3e82048630fbd45a7db48a5e65204b7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit 194cdf4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.