Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278205: jlink plugins should dump .class file in debug mode #6696

Closed
wants to merge 1 commit into from
Closed

8278205: jlink plugins should dump .class file in debug mode #6696

wants to merge 1 commit into from

Conversation

sundararajana
Copy link
Member

@sundararajana sundararajana commented Dec 3, 2021

jlink plugins dump .class files in debug mode. jpackage tests already set jlink.debug property to true.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278205: jlink plugins should dump .class file in debug mode

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6696/head:pull/6696
$ git checkout pull/6696

Update a local copy of the PR:
$ git checkout pull/6696
$ git pull https://git.openjdk.java.net/jdk pull/6696/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6696

View PR using the GUI difftool:
$ git pr show -t 6696

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6696.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 3, 2021

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2021

@sundararajana The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Dec 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 3, 2021

Webrevs

Copy link
Member

@JimLaskey JimLaskey left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2021

@sundararajana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278205: jlink plugins should dump .class file in debug mode

Reviewed-by: jlaskey

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • dda8f26: 8278139: G1: Refactor G1BlockOffsetTablePart::block_at_or_preceding
  • e4774e6: 8277916: Gather non-strong reference count logic in a single place
  • 53df9ff: 8278154: SimpleFileServer#createFileServer() should specify that the returned server is not started
  • d1cad24: 8278168: Add a few missing words to the specification of Files.mismatch
  • 45da3ae: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup
  • 8907003: 8272234: Pass originating elements from Filer to JavaFileManager
  • 0fbd271: 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx
  • bef5c7a: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
  • 473ecec: 8278174: runtime/cds/appcds/LambdaWithJavaAgent.java fails with release VMs
  • 19ce33d: 8258512: serviceability/sa/TestJmapCore.java timed out on macOS 10.13.6
  • ... and 28 more: https://git.openjdk.java.net/jdk/compare/a093cdddaf5ab88eb84a147e523db5c3e1be54be...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 3, 2021
@sundararajana
Copy link
Member Author

@sundararajana sundararajana commented Dec 3, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2021

Going to push as commit ba2a8e5.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 18c54b4: 8274640: Cleanup unnecessary null comparison before instanceof check in java.desktop
  • dda8f26: 8278139: G1: Refactor G1BlockOffsetTablePart::block_at_or_preceding
  • e4774e6: 8277916: Gather non-strong reference count logic in a single place
  • 53df9ff: 8278154: SimpleFileServer#createFileServer() should specify that the returned server is not started
  • d1cad24: 8278168: Add a few missing words to the specification of Files.mismatch
  • 45da3ae: 8278163: --with-cacerts-src variable resolved after GenerateCacerts recipe setup
  • 8907003: 8272234: Pass originating elements from Filer to JavaFileManager
  • 0fbd271: 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx
  • bef5c7a: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
  • 473ecec: 8278174: runtime/cds/appcds/LambdaWithJavaAgent.java fails with release VMs
  • ... and 29 more: https://git.openjdk.java.net/jdk/compare/a093cdddaf5ab88eb84a147e523db5c3e1be54be...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2021

@sundararajana Pushed as commit ba2a8e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
2 participants