8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id

[mgronlun]

Greetings,

please help review this changeset.

Details are listed in the JIRA issue.

Testing: jdk_jfr

Thanks
Markus

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id

Reviewers

• Erik Gahlin (@egahlin - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6702/head:pull/6702
$ git checkout pull/6702

Update a local copy of the PR:
$ git checkout pull/6702
$ git pull https://git.openjdk.java.net/jdk pull/6702/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6702

View PR using the GUI difftool:
$ git pr show -t 6702

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6702.diff

[bridgekeeper]

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mgronlun The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (22919a19)

[openjdk]

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id

Reviewed-by: egahlin, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 286a26c: 8278277: G1: Simplify implementation of G1GCPhaseTimes::record_or_add_time_secs
• d14f06a: 8278031: MultiThreadedRefCounter should not use relaxed atomic decrement
• 8d190dd: 8277496: Remove duplication in c1 Block successor lists
• 194cdf4: 8277864: Compilation error thrown while doing a boxing conversion on selector expression
• f39fe5b: 8154011: Make TraceDeoptimization a diagnostic flag
• f180a45: 8278016: Add compiler tests to tier{2,3}
• 104aa1f: 8268575: Annotations not visible on model elements before they are generated
• 839b606: 8278143: Remove unused "argc" from ConstantPool::copy_bootstrap_arguments_at_impl
• 267c024: 8265150: AsyncGetCallTrace crashes on ResourceMark
• 9642629: 8276779: (ch) InputStream returned by Channels.newInputStream should have fast path for SelectableChannels
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/f7237793ffa3a5a804fea49f165c8b9f1935cfac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Looks fine. Probably affects all releases, right? Even before Thread-SMR, the thread oop is not really guaranteed to be here?

[mgronlun]

"Looks fine. Probably affects all releases, right? Even before Thread-SMR, the thread oop is not really guaranteed to be here?"

I don't really remember. This is old code, but the sightings started to appear in the last couple of months. Perhaps it is a combo of SMR thread lists AND the Access API coming together? The earlier API in javaClasses.cpp handling null perhaps?

[mgronlun]

/integrate

[openjdk]

Going to push as commit a885aab.
Since your change was applied there have been 27 commits pushed to the master branch:

• 6994d80: 8278291: compiler/uncommontrap/TraceDeoptimizationNoRealloc.java fails with release VMs after JDK-8154011
• 286a26c: 8278277: G1: Simplify implementation of G1GCPhaseTimes::record_or_add_time_secs
• d14f06a: 8278031: MultiThreadedRefCounter should not use relaxed atomic decrement
• 8d190dd: 8277496: Remove duplication in c1 Block successor lists
• 194cdf4: 8277864: Compilation error thrown while doing a boxing conversion on selector expression
• f39fe5b: 8154011: Make TraceDeoptimization a diagnostic flag
• f180a45: 8278016: Add compiler tests to tier{2,3}
• 104aa1f: 8268575: Annotations not visible on model elements before they are generated
• 839b606: 8278143: Remove unused "argc" from ConstantPool::copy_bootstrap_arguments_at_impl
• 267c024: 8265150: AsyncGetCallTrace crashes on ResourceMark
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/f7237793ffa3a5a804fea49f165c8b9f1935cfac...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mgronlun Pushed as commit a885aab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mmyxym]

/backport jdk17u-dev

[openjdk]

@mmyxym the backport was successfully created on the branch backport-mmyxym-a885aab6 in my personal fork of openjdk/jdk17u-dev. To create a pull request with this backport targeting openjdk/jdk17u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit a885aab6 from the openjdk/jdk repository.

The commit being backported was authored by Markus Grönlund on 6 Dec 2021 and was reviewed by Erik Gahlin and Aleksey Shipilev.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk17u-dev:

$ git fetch https://github.com/openjdk-bots/jdk17u-dev.git backport-mmyxym-a885aab6:backport-mmyxym-a885aab6
$ git checkout backport-mmyxym-a885aab6
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk17u-dev.git backport-mmyxym-a885aab6

[sendaoYan]

Hi, where is the applications/runthese/RunThese24H.java, I can't find the runthese sub-directory in test/hotspot/jtreg/applications directory.

[mgronlun]

Hi, where is the applications/runthese/RunThese24H.java, I can't find the runthese sub-directory in test/hotspot/jtreg/applications directory.

Unfortunately, this test is in an internal, non-public, repository.