JDK-8154011: Make TraceDeoptimization a diagnostic flag

[tobiasholenstein]

Make TraceDeoptimization available in a product build.

I checked that performance is not affected on Aurora.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8154011: Make TraceDeoptimization a diagnostic flag

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6703/head:pull/6703
$ git checkout pull/6703

Update a local copy of the PR:
$ git checkout pull/6703
$ git pull https://git.openjdk.java.net/jdk pull/6703/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6703

View PR using the GUI difftool:
$ git pr show -t 6703

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6703.diff

[bridgekeeper]

👋 Welcome back tobiasholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tobiasholenstein The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cb4d0cc3)

[vnkozlov]

Good.

[openjdk]

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8154011: Make TraceDeoptimization a diagnostic flag

Reviewed-by: kvn, dholmes, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• f180a45: 8278016: Add compiler tests to tier{2,3}
• 104aa1f: 8268575: Annotations not visible on model elements before they are generated
• 839b606: 8278143: Remove unused "argc" from ConstantPool::copy_bootstrap_arguments_at_impl
• 267c024: 8265150: AsyncGetCallTrace crashes on ResourceMark
• 9642629: 8276779: (ch) InputStream returned by Channels.newInputStream should have fast path for SelectableChannels
• 02ee337: 8278175: Enable all doclint warnings for build of java.desktop
• 24e16ac: 8277617: Adjust AVX3Threshold for copy/fill stubs
• 2b87c2b: 8277793: Support vector F2I and D2L cast operations for X86
• e1cde19: 8278247: KeyStoreSpi::engineGetAttributes does not throws KeyStoreException
• a729a70: 8225181: KeyStore should have a getAttributes method
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/f7237793ffa3a5a804fea49f165c8b9f1935cfac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @dholmes-ora, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dholmes-ora]

Change looks fine, though as I mention in JBS maybe this could be converted to unified logging?

Cheers,
David

[tobiasholenstein]

/label add hotspot-compiler

[openjdk]

@tobiasholenstein
The hotspot-compiler label was successfully added.

[TobiHartmann]

Looks good to me and as discussed in JIRA, this can't be easily converted to UL.

[tobiasholenstein]

/integrate

[openjdk]

@tobiasholenstein
Your change (at version cb4d0cc) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit f39fe5b.
Since your change was applied there have been 21 commits pushed to the master branch:

• f180a45: 8278016: Add compiler tests to tier{2,3}
• 104aa1f: 8268575: Annotations not visible on model elements before they are generated
• 839b606: 8278143: Remove unused "argc" from ConstantPool::copy_bootstrap_arguments_at_impl
• 267c024: 8265150: AsyncGetCallTrace crashes on ResourceMark
• 9642629: 8276779: (ch) InputStream returned by Channels.newInputStream should have fast path for SelectableChannels
• 02ee337: 8278175: Enable all doclint warnings for build of java.desktop
• 24e16ac: 8277617: Adjust AVX3Threshold for copy/fill stubs
• 2b87c2b: 8277793: Support vector F2I and D2L cast operations for X86
• e1cde19: 8278247: KeyStoreSpi::engineGetAttributes does not throws KeyStoreException
• a729a70: 8225181: KeyStore should have a getAttributes method
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/f7237793ffa3a5a804fea49f165c8b9f1935cfac...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @tobiasholenstein Pushed as commit f39fe5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dougxc]

Sorry for only bringing it up now, but @tkrodriguez just observed that several of the places that test TraceDeoptimization aren't included in a PRODUCT build. In particular, here, here, and here. Without these bits of code included, the functionality of TraceDeoptimzation is somewhat compromised.

[vnkozlov]

@tobiasholenstein please file follow up bug and fix places pointed by Doug.
Also make sure run testing to find and fix affected tests.

[tkrodriguez]

Some of those might be benign, thought they are inconsistent. The DEOPT PACKING messages are controlled by PrintDeoptimizationDetails, but DEOPT UNPACKING is controlled by TraceDeoptimization. The REALLOC messages could likely be under PrintDeoptimizationDetails. Maybe it would make sense to rationalize them a bit and make PrintDeoptimizationDetails diagnostic as well.

[tobiasholenstein]

Thanks for catching that! I filed a Bug on JIRA (JDK-8278329)