Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278247: KeyStoreSpi::engineGetAttributes does not throws KeyStoreException #6706

Closed
wants to merge 1 commit into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Dec 3, 2021

The specification wrongly claims there could be an exception thrown, but it's not true.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278247: KeyStoreSpi::engineGetAttributes does not throws KeyStoreException

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6706/head:pull/6706
$ git checkout pull/6706

Update a local copy of the PR:
$ git checkout pull/6706
$ git pull https://git.openjdk.java.net/jdk pull/6706/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6706

View PR using the GUI difftool:
$ git pr show -t 6706

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6706.diff

…eption

8278247: KeyStoreSpi::engineGetAttributes does not throws KeyStoreException
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 3, 2021

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2021

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Dec 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 3, 2021

Webrevs

Copy link
Member

@seanjmullan seanjmullan left a comment

Looks good. Add a noreg-doc or something similar to the bug.

@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Dec 3, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2021

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278247: KeyStoreSpi::engineGetAttributes does not throws KeyStoreException

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2021

Going to push as commit e1cde19.

@openjdk openjdk bot closed this Dec 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2021

@wangweij Pushed as commit e1cde19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8278247 branch Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
2 participants