Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278166: java/nio/channels/Channels/TransferTo.java timed out #6707

Closed
wants to merge 6 commits into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Dec 3, 2021

In the testMoreThanTwoGB() sub-test, only fill the last section of the file with random data in order to reduce test execution time.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278166: java/nio/channels/Channels/TransferTo.java timed out

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6707/head:pull/6707
$ git checkout pull/6707

Update a local copy of the PR:
$ git checkout pull/6707
$ git pull https://git.openjdk.java.net/jdk pull/6707/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6707

View PR using the GUI difftool:
$ git pr show -t 6707

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6707.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 3, 2021

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@bplb
Copy link
Member Author

@bplb bplb commented Dec 3, 2021

Total time to run this test locally decreased by about 25% on my development laptop.

@openjdk openjdk bot added the rfr label Dec 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2021

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio label Dec 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 3, 2021

Webrevs

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Looks OK overall. Minor comment below

test/jdk/java/nio/channels/Channels/TransferTo.java Outdated Show resolved Hide resolved
@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2021

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278166: java/nio/channels/Channels/TransferTo.java timed out

Reviewed-by: lancea, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • ea8d3c9: 8271566: DSA signature length value is not accurate in P11Signature
  • 239362d: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList
  • 2c31a17: 8275082: Update XML Security for Java to 2.3.0
  • 70bad89: 8277497: Last column cell in the JTAble row is read as empty cell
  • 5045eb5: 8278273: Remove unnecessary exclusion of doclint accessibility checks

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 3, 2021
Copy link
Contributor

@AlanBateman AlanBateman left a comment

This is much better, just some minor comments and I think we are good to go. There are probably other tests with large files that could benefit from the same thing.

test/jdk/java/nio/channels/Channels/TransferTo.java Outdated Show resolved Hide resolved
test/jdk/java/nio/channels/Channels/TransferTo.java Outdated Show resolved Hide resolved
test/jdk/java/nio/channels/Channels/TransferTo.java Outdated Show resolved Hide resolved
Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Looks Good Brian.

For continuity, did you give any thoughts of making the same change to targetFile as you did for sourceFile to avoid using Files.createTempfile?

@bplb
Copy link
Member Author

@bplb bplb commented Dec 6, 2021

@LanceAndersen Changed targetFile init to similar to sourceFile init.

@bplb
Copy link
Member Author

@bplb bplb commented Dec 7, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2021

Going to push as commit 7ea4b19.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 543d1a8: 8275721: Name of UTC timezone in a locale changes depending on previous code
  • bd7c54a: 8278341: Liveness check for global scope is not as fast as it could be
  • c609b5d: 8277628: Spec for InetAddressResolverProvider::get() throwing error or exception could be clearer
  • bb50b92: 8277536: Use String.blank in jdk.javadoc where applicable
  • 5b81d5e: 8276901: Implement UseHeavyMonitors consistently
  • 69d8669: 8278339: ServerSocket::isClosed may return false after accept throws
  • 56ca66e: 8277863: Deprecate sun.misc.Unsafe methods that return offsets
  • 3536127: 8277383: VM.metaspace optionally show chunk freelist details
  • 44fcee3: 8278289: Drop G1BlockOffsetTablePart::_object_can_span
  • b2638e5: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/587e5409c2488cf8c3579a4932c588efc5a02749...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2021

@bplb Pushed as commit 7ea4b19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the Channels-TransferTo-8278166 branch Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated nio
3 participants