8278166: java/nio/channels/Channels/TransferTo.java timed out

[bplb]

In the testMoreThanTwoGB() sub-test, only fill the last section of the file with random data in order to reduce test execution time.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8278166: java/nio/channels/Channels/TransferTo.java timed out

Reviewers

• Lance Andersen (@LanceAndersen - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to a4da4f3

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6707/head:pull/6707
$ git checkout pull/6707

Update a local copy of the PR:
$ git checkout pull/6707
$ git pull https://git.openjdk.java.net/jdk pull/6707/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6707

View PR using the GUI difftool:
$ git pr show -t 6707

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6707.diff

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[bplb]

Total time to run this test locally decreased by about 25% on my development laptop.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (96c87746)
• 03: Full - Incremental (a4da4f3a)
• 02: Full - Incremental (a384a4f3)
• 01: Full - Incremental (88a0e72d)
• 00: Full (29c4e9f4)

[LanceAndersen]

Looks OK overall. Minor comment below

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278166: java/nio/channels/Channels/TransferTo.java timed out

Reviewed-by: lancea, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• ea8d3c9: 8271566: DSA signature length value is not accurate in P11Signature
• 239362d: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList
• 2c31a17: 8275082: Update XML Security for Java to 2.3.0
• 70bad89: 8277497: Last column cell in the JTAble row is read as empty cell
• 5045eb5: 8278273: Remove unnecessary exclusion of doclint accessibility checks

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlanBateman]

This is much better, just some minor comments and I think we are good to go. There are probably other tests with large files that could benefit from the same thing.

[LanceAndersen]

Looks Good Brian.

For continuity, did you give any thoughts of making the same change to targetFile as you did for sourceFile to avoid using Files.createTempfile?

[bplb]

@LanceAndersen Changed targetFile init to similar to sourceFile init.

[bplb]

/integrate

[openjdk]

Going to push as commit 7ea4b19.
Since your change was applied there have been 22 commits pushed to the master branch:

• 543d1a8: 8275721: Name of UTC timezone in a locale changes depending on previous code
• bd7c54a: 8278341: Liveness check for global scope is not as fast as it could be
• c609b5d: 8277628: Spec for InetAddressResolverProvider::get() throwing error or exception could be clearer
• bb50b92: 8277536: Use String.blank in jdk.javadoc where applicable
• 5b81d5e: 8276901: Implement UseHeavyMonitors consistently
• 69d8669: 8278339: ServerSocket::isClosed may return false after accept throws
• 56ca66e: 8277863: Deprecate sun.misc.Unsafe methods that return offsets
• 3536127: 8277383: VM.metaspace optionally show chunk freelist details
• 44fcee3: 8278289: Drop G1BlockOffsetTablePart::_object_can_span
• b2638e5: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test
• ... and 12 more: https://git.openjdk.java.net/jdk/compare/587e5409c2488cf8c3579a4932c588efc5a02749...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 7ea4b19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.