-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8278166: java/nio/channels/Channels/TransferTo.java timed out #6707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back bpb! A progress list of the required criteria for merging this PR into |
Total time to run this test locally decreased by about 25% on my development laptop. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK overall. Minor comment below
@bplb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better, just some minor comments and I think we are good to go. There are probably other tests with large files that could benefit from the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good Brian.
For continuity, did you give any thoughts of making the same change to targetFile as you did for sourceFile to avoid using Files.createTempfile?
…eous formatting cleanup
@LanceAndersen Changed targetFile init to similar to sourceFile init. |
/integrate |
Going to push as commit 7ea4b19.
Your commit was automatically rebased without conflicts. |
In the
testMoreThanTwoGB()
sub-test, only fill the last section of the file with random data in order to reduce test execution time.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6707/head:pull/6707
$ git checkout pull/6707
Update a local copy of the PR:
$ git checkout pull/6707
$ git pull https://git.openjdk.java.net/jdk pull/6707/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6707
View PR using the GUI difftool:
$ git pr show -t 6707
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6707.diff