Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6606767: resexhausted00[34] fail assert(!thread->owns_locks(), "must release all locks when leaving VM") #671

Closed
wants to merge 1 commit into from

Conversation

@alexmenkov
Copy link

@alexmenkov alexmenkov commented Oct 14, 2020

Please review the fix for JDK-6606767.
The original issue is not reproducible.
The fix:

  • resexhausted003 and resexhausted004 are un-problemlisted
  • resexhausted004 is problemlisted on linux due JDK-8253916 (resexhausted004 executes resexhausted001/resexhausted002/resexhausted003 randomly, and resexhausted001 fails on linux)
  • resexhausted003 is updated to throw SkippedException if OOME is not thrown;
  • resexhausted004 is updated to catch SkippedException from resexhausted001..003, also logic is slightly simplified

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-6606767: resexhausted00[34] fail assert(!thread->owns_locks(), "must release all locks when leaving VM")

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/671/head:pull/671
$ git checkout pull/671

…release all locks when leaving VM")

The original issue is not reproducible.
The fix:
- resexhausted003 and resexhausted004 are un-problemlisted
- resexhausted004 is problemlisted on linux due JDK-8253916 (resexhausted004 executes resexhausted001/resexhausted002/resexhausted003 randomly, and resexhausted001 fails on linux)
- resexhausted003 is updated to throw SkippedException if OOME is not thrown;
- resexhausted004 is updated to catch SkippedException from resexhausted001..003, also logic is slightly simplified
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 14, 2020

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@alexmenkov The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 14, 2020

Webrevs

Loading

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Hi Alex,
I'm okay with this fix.
Thanks,
Serguei

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2020

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6606767: resexhausted00[34] fail assert(!thread->owns_locks(), "must release all locks when leaving VM")

Reviewed-by: sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 115 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 14, 2020
Copy link
Contributor

@plummercj plummercj left a comment

Looks good.

Loading

@alexmenkov
Copy link
Author

@alexmenkov alexmenkov commented Oct 21, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 21, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 21, 2020
@alexmenkov alexmenkov deleted the resexhausted003 branch Oct 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2020

@alexmenkov Since your change was applied there have been 144 commits pushed to the master branch:

  • 1191a63: 8199697: FIPS 186-4 RSA Key Generation
  • 60d3fa2: 8255022: Documentation missing for Vector API zero methods
  • 9ade94b: 8206311: Add docs-javase, docs-reference to CI build
  • 3445031: 8255200: ProblemList com/sun/jdi/EATests.java for ZGC
  • 85a8949: 8254913: Increase InlineSmallCode default from 2000 to 2500 for x64
  • 56ea490: 8233343: Deprecate -XX:+CriticalJNINatives flag which implements JavaCritical native functions
  • 615b759: 8255070: Shenandoah: Use single thread for concurrent CLD liveness test
  • 6020991: 8255068: [JVMCI] errors during compiler creation can be hidden
  • 8d9e6d0: 8255041: Zero: remove old JSR 292 support leftovers
  • 0efdde1: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic)
  • ... and 134 more: https://git.openjdk.java.net/jdk/compare/cd33abb136d415455090cef4fe6211d9e6940948...master

Your commit was automatically rebased without conflicts.

Pushed as commit b9186be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants