Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList #6710

Closed
wants to merge 5 commits into from

Conversation

anupamdev20
Copy link
Contributor

@anupamdev20 anupamdev20 commented Dec 4, 2021

The documentation for following methods used object equality mentioning 'equals()'. I have replaced the equals() with == operator where necessary with some formattings.

sun.awt.util.IdentityLinkedList#contains
sun.awt.util.IdentityArrayList#contains
sun.awt.util.IdentityArrayList#indexOf
sun.awt.util.IdentityArrayList#lastIndexOf
sun.awt.util.IdentityArrayList#remove(java.lang.Object)

Kindly review the change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6710/head:pull/6710
$ git checkout pull/6710

Update a local copy of the PR:
$ git checkout pull/6710
$ git pull https://git.openjdk.java.net/jdk pull/6710/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6710

View PR using the GUI difftool:
$ git pr show -t 6710

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6710.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 4, 2021

👋 Welcome back anupamdev20! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 4, 2021

⚠️ @anupamdev20 This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the rfr label Dec 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 4, 2021

@anupamdev20 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Dec 4, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 4, 2021

Webrevs

@aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Dec 4, 2021

Was the previous PR #6694 not good enough?
The previous PR has comments to the changes thus you should've referenced it when you created the new one.

@anupamdev20
Copy link
Contributor Author

@anupamdev20 anupamdev20 commented Dec 5, 2021

@aivanov-jdk The PR #6694 included HttpURLConnection too. I therefore closed that PR (#6694 (review)) and initiated new requested with correct files and changes. As I am slightly new to git I did not know how to update the PR, so I filed a new one.

@aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Dec 6, 2021

@aivanov-jdk The PR #6694 included HttpURLConnection too. I therefore closed that PR (#6694 (review)) and initiated new requested with correct files and changes. As I am slightly new to git I did not know how to update the PR, so I filed a new one.

You could've just reverted the changes to HttpURLConnection in your branch and pushed. Effectively, it would've removed the change from the PR.

prrace
prrace approved these changes Dec 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

@anupamdev20 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList

Reviewed-by: aivanov, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 2c31a17: 8275082: Update XML Security for Java to 2.3.0
  • 70bad89: 8277497: Last column cell in the JTAble row is read as empty cell
  • 5045eb5: 8278273: Remove unnecessary exclusion of doclint accessibility checks
  • 587e540: 8210558: serviceability/sa/TestJhsdbJstackLock.java fails to find '^\s+- waiting to lock <0x[0-9a-f]+> (a java.lang.Class ...'
  • 082fdf4: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • ab78187: 8277105: Inconsistent handling of missing permitted subclasses
  • adf3952: 8277372: Add getters for BOT and card table members
  • 7c6f57f: 8275610: C2: Object field load floats above its null check resulting in a segfault
  • a885aab: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
  • 6994d80: 8278291: compiler/uncommontrap/TraceDeoptimizationNoRealloc.java fails with release VMs after JDK-8154011
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/02ee337ae0d163ae44b1691eb9de12c5608ba178...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk, @prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Dec 6, 2021
….java

Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk@users.noreply.github.com>
@anupamdev20
Copy link
Contributor Author

@anupamdev20 anupamdev20 commented Dec 6, 2021

/integrate

@openjdk openjdk bot added the sponsor label Dec 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

@anupamdev20
Your change (at version 1bd337a) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Dec 6, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

Going to push as commit 239362d.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 2c31a17: 8275082: Update XML Security for Java to 2.3.0
  • 70bad89: 8277497: Last column cell in the JTAble row is read as empty cell
  • 5045eb5: 8278273: Remove unnecessary exclusion of doclint accessibility checks
  • 587e540: 8210558: serviceability/sa/TestJhsdbJstackLock.java fails to find '^\s+- waiting to lock <0x[0-9a-f]+> (a java.lang.Class ...'
  • 082fdf4: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • ab78187: 8277105: Inconsistent handling of missing permitted subclasses
  • adf3952: 8277372: Add getters for BOT and card table members
  • 7c6f57f: 8275610: C2: Object field load floats above its null check resulting in a segfault
  • a885aab: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
  • 6994d80: 8278291: compiler/uncommontrap/TraceDeoptimizationNoRealloc.java fails with release VMs after JDK-8154011
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/02ee337ae0d163ae44b1691eb9de12c5608ba178...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Dec 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

@aivanov-jdk @anupamdev20 Pushed as commit 239362d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated
3 participants