Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278276: G1: Refine naming of G1GCParPhaseTimesTracker::_must_record #6714

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Dec 6, 2021

This is a trivial improvement to refine the naming of G1GCParPhaseTimesTracker::_must_record to _initial_record.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278276: G1: Refine naming of G1GCParPhaseTimesTracker::_must_record

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6714/head:pull/6714
$ git checkout pull/6714

Update a local copy of the PR:
$ git checkout pull/6714
$ git pull https://git.openjdk.java.net/jdk pull/6714/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6714

View PR using the GUI difftool:
$ git pr show -t 6714

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6714.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 6, 2021
@openjdk
Copy link

openjdk bot commented Dec 6, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 6, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 6, 2021

Webrevs

@kstefanj
Copy link
Contributor

kstefanj commented Dec 6, 2021

I wonder if we could find an even better name than initial_record. The member is there to tell whether or not we can have multiple instances using the same phase. So something like single_record would be more accurate imho.

An alternative would be to switch the bool to be false by default and call it something like allow_multiple_record, not sure this is better. Let's here what other thinks.

@Hamlin-Li
Copy link
Author

Hamlin-Li commented Dec 6, 2021

Thanks Stefan, I think your suggestion is better, I prefer allow_multiple_record, let's see others' opinion.

@tschatzl
Copy link
Contributor

tschatzl commented Dec 6, 2021

I prefer allow_multiple_record too.

@Hamlin-Li
Copy link
Author

Hamlin-Li commented Dec 7, 2021

Thanks Thomas for confirmation.

Copy link
Contributor

@kstefanj kstefanj left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Dec 7, 2021

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278276: G1: Refine naming of G1GCParPhaseTimesTracker::_must_record

Reviewed-by: sjohanss, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 113 new commits pushed to the master branch:

  • d7ad546: 8276422: Add command-line option to disable finalization
  • ec7cb6d: 8276447: Deprecate finalization-related methods for removal
  • 3c2951f: 8275771: JDK source code contains redundant boolean operations in jdk.compiler and langtools
  • 3d61372: 8278363: Create extented container test groups
  • 716c2e1: 8278368: ProblemList tools/jpackage/share/MultiNameTwoPhaseTest.java on macosx-x64
  • a8a1fbc: 8278068: Fix next-line modifier (snippet markup)
  • 061017a: 8273175: Add @SInCE tags to the DocTree.Kind enum constants
  • d7c283a: 8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression
  • 3955b03: 8277328: jdk/jshell/CommandCompletionTest.java failures on Windows
  • 5a036ac: 8277990: NMT: Remove NMT shutdown capability
  • ... and 103 more: https://git.openjdk.java.net/jdk/compare/67745fa749e5075b37aeca7db9d446bc287da835...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 7, 2021
@Hamlin-Li
Copy link
Author

Hamlin-Li commented Dec 7, 2021

Can I get another approval, or this is trivial? :)

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm. Please fix the issue with the copyright date before pushing.

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
Copy link
Contributor

@tschatzl tschatzl Dec 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights reserved.

@Hamlin-Li
Copy link
Author

Hamlin-Li commented Dec 8, 2021

Thanks @tschatzl @kstefanj for your reviews.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 8, 2021

Going to push as commit fb6d611.
Since your change was applied there have been 113 commits pushed to the master branch:

  • d7ad546: 8276422: Add command-line option to disable finalization
  • ec7cb6d: 8276447: Deprecate finalization-related methods for removal
  • 3c2951f: 8275771: JDK source code contains redundant boolean operations in jdk.compiler and langtools
  • 3d61372: 8278363: Create extented container test groups
  • 716c2e1: 8278368: ProblemList tools/jpackage/share/MultiNameTwoPhaseTest.java on macosx-x64
  • a8a1fbc: 8278068: Fix next-line modifier (snippet markup)
  • 061017a: 8273175: Add @SInCE tags to the DocTree.Kind enum constants
  • d7c283a: 8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression
  • 3955b03: 8277328: jdk/jshell/CommandCompletionTest.java failures on Windows
  • 5a036ac: 8277990: NMT: Remove NMT shutdown capability
  • ... and 103 more: https://git.openjdk.java.net/jdk/compare/67745fa749e5075b37aeca7db9d446bc287da835...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2021
@openjdk
Copy link

openjdk bot commented Dec 8, 2021

@Hamlin-Li Pushed as commit fb6d611.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants