Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278277 G1: Simplify implementation of G1GCPhaseTimes::record_or_add_time_secs #6715

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Dec 6, 2021

This is a minor improvement of G1GCPhaseTimes::record_or_add_time_secs to reuse WorkerDataArray::set_or_add rather than implement the logic in G1GCPhaseTimes itself.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278277: G1: Simplify implementation of G1GCPhaseTimes::record_or_add_time_secs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6715/head:pull/6715
$ git checkout pull/6715

Update a local copy of the PR:
$ git checkout pull/6715
$ git pull https://git.openjdk.java.net/jdk pull/6715/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6715

View PR using the GUI difftool:
$ git pr show -t 6715

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6715.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 6, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Dec 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 6, 2021

Webrevs

Copy link
Member

@walulyai walulyai left a comment

Lgtm!

@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278277: G1: Simplify implementation of G1GCPhaseTimes::record_or_add_time_secs

Reviewed-by: iwalulya, sjohanss, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

  • 8d190dd: 8277496: Remove duplication in c1 Block successor lists
  • 194cdf4: 8277864: Compilation error thrown while doing a boxing conversion on selector expression
  • f39fe5b: 8154011: Make TraceDeoptimization a diagnostic flag
  • f180a45: 8278016: Add compiler tests to tier{2,3}
  • 104aa1f: 8268575: Annotations not visible on model elements before they are generated
  • 839b606: 8278143: Remove unused "argc" from ConstantPool::copy_bootstrap_arguments_at_impl
  • 267c024: 8265150: AsyncGetCallTrace crashes on ResourceMark
  • 9642629: 8276779: (ch) InputStream returned by Channels.newInputStream should have fast path for SelectableChannels
  • 02ee337: 8278175: Enable all doclint warnings for build of java.desktop
  • 24e16ac: 8277617: Adjust AVX3Threshold for copy/fill stubs
  • ... and 60 more: https://git.openjdk.java.net/jdk/compare/67745fa749e5075b37aeca7db9d446bc287da835...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 6, 2021
@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Dec 6, 2021

Thanks @tschatzl @kstefanj @walulyai for your reviews.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

Going to push as commit 286a26c.
Since your change was applied there have been 71 commits pushed to the master branch:

  • d14f06a: 8278031: MultiThreadedRefCounter should not use relaxed atomic decrement
  • 8d190dd: 8277496: Remove duplication in c1 Block successor lists
  • 194cdf4: 8277864: Compilation error thrown while doing a boxing conversion on selector expression
  • f39fe5b: 8154011: Make TraceDeoptimization a diagnostic flag
  • f180a45: 8278016: Add compiler tests to tier{2,3}
  • 104aa1f: 8268575: Annotations not visible on model elements before they are generated
  • 839b606: 8278143: Remove unused "argc" from ConstantPool::copy_bootstrap_arguments_at_impl
  • 267c024: 8265150: AsyncGetCallTrace crashes on ResourceMark
  • 9642629: 8276779: (ch) InputStream returned by Channels.newInputStream should have fast path for SelectableChannels
  • 02ee337: 8278175: Enable all doclint warnings for build of java.desktop
  • ... and 61 more: https://git.openjdk.java.net/jdk/compare/67745fa749e5075b37aeca7db9d446bc287da835...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

@Hamlin-Li Pushed as commit 286a26c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the simplifyG1GCPhaseTimes-record_or_add_time_secs branch Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
4 participants