Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278289: Drop G1BlockOffsetTablePart::_object_can_span #6718

Closed
wants to merge 2 commits into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Dec 6, 2021

Simple change of dropping a debug-only field. Instead, the assert logic queries for the region type directly.

Test: tier1-5


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278289: Drop G1BlockOffsetTablePart::_object_can_span

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6718/head:pull/6718
$ git checkout pull/6718

Update a local copy of the PR:
$ git checkout pull/6718
$ git pull https://git.openjdk.java.net/jdk pull/6718/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6718

View PR using the GUI difftool:
$ git pr show -t 6718

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6718.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 6, 2021
@openjdk
Copy link

openjdk bot commented Dec 6, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 6, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 6, 2021

Webrevs

src/hotspot/share/gc/g1/g1BlockOffsetTable.inline.hpp Outdated Show resolved Hide resolved
src/hotspot/share/gc/g1/g1BlockOffsetTable.inline.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm.

@openjdk
Copy link

openjdk bot commented Dec 7, 2021

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278289: Drop G1BlockOffsetTablePart::_object_can_span

Reviewed-by: tschatzl, sjohanss, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 7, 2021
@albertnetymk
Copy link
Member Author

albertnetymk commented Dec 7, 2021

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 7, 2021

Going to push as commit 44fcee3.
Since your change was applied there have been 50 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 7, 2021
@openjdk
Copy link

openjdk bot commented Dec 7, 2021

@albertnetymk Pushed as commit 44fcee3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the bot-can-span branch Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
4 participants