JDK-8254796: Cleanup pervasive unnecessary parameter #672
Conversation
|
|
|
@jonathan-gibbons The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
| } | ||
|
|
||
| void generate() throws DocFileIOException, SimpleDocletException { | ||
| if (docEnv == null || outputdir == null) { |
kusrinivasan
Oct 16, 2020
•
Member
Why was it checking for docEnv or RootDoc being null ? Was this ever being called without RootDoc being initialized ?
Why was it checking for docEnv or RootDoc being null ? Was this ever being called without RootDoc being initialized ?
jonathan-gibbons
Oct 19, 2020
Author
Contributor
It's hard to believe the value was ever null, at least in normal operation.
It's hard to believe the value was ever null, at least in normal operation.
|
Generally the changes are fine, I had a question about the old world specific to why RootDoc would be null if generate was called, but again the old world had a lot of goofy things going on. |
|
@jonathan-gibbons This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 75 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
|
/integrate |
|
@jonathan-gibbons Since your change was applied there have been 75 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 60f63ec. |
This is a small cleanup to remove an annoying extra parameter (docEnv) being based around when creating the doclet.
(there's a hint of the old world too, when it is referred to as "rd" in one place, short for "RootDoc": the corresponding class in the old world ;-) )
Progress
Testing
Failed test task
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/672/head:pull/672$ git checkout pull/672