Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278291: compiler/uncommontrap/TraceDeoptimizationNoRealloc.java fails with release VMs after JDK-8154011 #6721

Closed
wants to merge 2 commits into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Dec 6, 2021

Hi all,

compiler/uncommontrap/TraceDeoptimizationNoRealloc.java fails with release VMs after JDK-8154011 due 'TraceDeoptimization' is diagnostic and must be enabled via -XX:+UnlockDiagnosticVMOptions.
Let's add -XX:+UnlockDiagnosticVMOptions to fix it.

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278291: compiler/uncommontrap/TraceDeoptimizationNoRealloc.java fails with release VMs after JDK-8154011

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6721/head:pull/6721
$ git checkout pull/6721

Update a local copy of the PR:
$ git checkout pull/6721
$ git pull https://git.openjdk.java.net/jdk pull/6721/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6721

View PR using the GUI difftool:
$ git pr show -t 6721

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6721.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 6, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

@DamonFool The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Dec 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 6, 2021

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

Seems to me that IgnoreUnrecognizedVMOptions should be replaced with UnlockDiagnosticVMOptions. The first one made sense when option was develop and not recognized in release builds.

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Dec 6, 2021

Seems to me that IgnoreUnrecognizedVMOptions should be replaced with UnlockDiagnosticVMOptions. The first one made sense when option was develop and not recognized in release builds.

Good catch!
Updated.
Thanks @shipilev .

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good and trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278291: compiler/uncommontrap/TraceDeoptimizationNoRealloc.java fails with release VMs after JDK-8154011

Reviewed-by: shade, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 286a26c: 8278277: G1: Simplify implementation of G1GCPhaseTimes::record_or_add_time_secs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 6, 2021
Copy link
Contributor

@shipilev shipilev left a comment

Looks fine. Please test both release and fastdebug builds before pushing.

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Dec 6, 2021

Looks fine. Please test both release and fastdebug builds before pushing.

Thanks @TobiHartmann and @shipilev .
Both passed on Linux/x64.
So integrate it.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

Going to push as commit 6994d80.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 286a26c: 8278277: G1: Simplify implementation of G1GCPhaseTimes::record_or_add_time_secs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

@DamonFool Pushed as commit 6994d80.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8278291 branch Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants