Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277628: Spec for InetAddressResolverProvider::get() throwing error or exception could be clearer #6725

Conversation

AlekseiEfimov
Copy link
Member

@AlekseiEfimov AlekseiEfimov commented Dec 6, 2021

The following fix clarifies spec for InetAddressResolverProvider.get(Configuration) method to state that an error or exception thrown by this method will be propagated to to the caller of the method that triggered the lookup operation.

The InetAddressResolverProvider#system-wide-resolver class-level javadoc section has been updated to state the same.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277628: Spec for InetAddressResolverProvider::get() throwing error or exception could be clearer

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6725/head:pull/6725
$ git checkout pull/6725

Update a local copy of the PR:
$ git checkout pull/6725
$ git pull https://git.openjdk.java.net/jdk pull/6725/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6725

View PR using the GUI difftool:
$ git pr show -t 6725

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6725.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2021

👋 Welcome back aefimov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 6, 2021
@openjdk
Copy link

openjdk bot commented Dec 6, 2021

@AlekseiEfimov The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Dec 6, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 6, 2021

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated wording looks okay, I agree with the submitter that "calling thread" was a bit confusing.

@openjdk
Copy link

openjdk bot commented Dec 6, 2021

@AlekseiEfimov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277628: Spec for InetAddressResolverProvider::get() throwing error or exception could be clearer

Reviewed-by: alanb, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

  • 587e540: 8210558: serviceability/sa/TestJhsdbJstackLock.java fails to find '^\s+- waiting to lock <0x[0-9a-f]+> (a java.lang.Class ...'
  • 082fdf4: 8172065: javax/swing/JTree/4908142/bug4908142.java The selected index should be "aad"
  • ab78187: 8277105: Inconsistent handling of missing permitted subclasses
  • adf3952: 8277372: Add getters for BOT and card table members
  • 7c6f57f: 8275610: C2: Object field load floats above its null check resulting in a segfault
  • a885aab: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
  • 6994d80: 8278291: compiler/uncommontrap/TraceDeoptimizationNoRealloc.java fails with release VMs after JDK-8154011
  • 286a26c: 8278277: G1: Simplify implementation of G1GCPhaseTimes::record_or_add_time_secs
  • d14f06a: 8278031: MultiThreadedRefCounter should not use relaxed atomic decrement
  • 8d190dd: 8277496: Remove duplication in c1 Block successor lists
  • ... and 77 more: https://git.openjdk.java.net/jdk/compare/37ff7f3b66eaa74d62d6a93f2f34ec744db21834...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 6, 2021
Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekseiEfimov
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 7, 2021

Going to push as commit c609b5d.
Since your change was applied there have been 106 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 7, 2021
@openjdk
Copy link

openjdk bot commented Dec 7, 2021

@AlekseiEfimov Pushed as commit c609b5d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@AlekseiEfimov AlekseiEfimov deleted the JDK-8277628_clarify_provider_get_spec branch November 4, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
3 participants