New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8277628: Spec for InetAddressResolverProvider::get() throwing error or exception could be clearer #6725
Conversation
…r exception could be clearer
👋 Welcome back aefimov! A progress list of the required criteria for merging this PR into |
@AlekseiEfimov The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated wording looks okay, I agree with the submitter that "calling thread" was a bit confusing.
@AlekseiEfimov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 87 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/integrate |
Going to push as commit c609b5d.
Your commit was automatically rebased without conflicts. |
@AlekseiEfimov Pushed as commit c609b5d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The following fix clarifies spec for
InetAddressResolverProvider.get(Configuration)
method to state that an error or exception thrown by this method will be propagated to to the caller of the method that triggered the lookup operation.The
InetAddressResolverProvider#system-wide-resolver
class-level javadoc section has been updated to state the same.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6725/head:pull/6725
$ git checkout pull/6725
Update a local copy of the PR:
$ git checkout pull/6725
$ git pull https://git.openjdk.java.net/jdk pull/6725/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6725
View PR using the GUI difftool:
$ git pr show -t 6725
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6725.diff