Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277932: Subject:callAs() not throwing NPE when action is null #6728

Closed
wants to merge 1 commit into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Dec 6, 2021

Add null check. I must have thought the NPE will be thrown anyway but the catch Exception block swallows it.

I added a noreg-trivial label. If you think differently can add one.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277932: Subject:callAs() not throwing NPE when action is null

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6728/head:pull/6728
$ git checkout pull/6728

Update a local copy of the PR:
$ git checkout pull/6728
$ git pull https://git.openjdk.java.net/jdk pull/6728/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6728

View PR using the GUI difftool:
$ git pr show -t 6728

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6728.diff

8277932: Subject:callAs() not throwing NPE when action is null
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 6, 2021

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Dec 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 6, 2021

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Yes, the stack trace will be more useful with the explicit check, otherwise it would be buried inside other calls and it won't be so obvious that the argument passed to callAs is null.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 6, 2021

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277932: Subject:callAs() not throwing NPE when action is null

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 2ff1296: 8277957: Add test group for IPv6 exclusive testing
  • ea8d3c9: 8271566: DSA signature length value is not accurate in P11Signature
  • 239362d: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 6, 2021
@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Dec 7, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2021

Going to push as commit 10db0e4.
Since your change was applied there have been 4 commits pushed to the master branch:

  • f148e3e: 8278318: Create {@Index} entries for key LangTools terms
  • 2ff1296: 8277957: Add test group for IPv6 exclusive testing
  • ea8d3c9: 8271566: DSA signature length value is not accurate in P11Signature
  • 239362d: 8247973: Javadoc incorrect for IdentityArrayList, IdentityLinkedList

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2021

@wangweij Pushed as commit 10db0e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Dec 7, 2021

Is there a test for this? (I see noreg-trivial is added but a test should be easy to add).

@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Dec 7, 2021

Is there a test for this? (I see noreg-trivial is added but a test should be easy to add).

I can add one, just thought it's not necessary. I didn't say noreg-hard. :-)

@wangweij wangweij deleted the 8277932 branch Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
3 participants