Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272395: Bad HTML in JVMTI man page #6730

Closed
wants to merge 1 commit into from
Closed

Conversation

sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented Dec 7, 2021

This fix adds escaping of invalid characters '[]' for 3 URLs defined in the jvmti.xml.
This file is a base to generate the jvmti.html.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6730/head:pull/6730
$ git checkout pull/6730

Update a local copy of the PR:
$ git checkout pull/6730
$ git pull https://git.openjdk.java.net/jdk pull/6730/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6730

View PR using the GUI difftool:
$ git pr show -t 6730

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6730.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 7, 2021

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2021

@sspitsyn The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability hotspot labels Dec 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 7, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good and trivial.

I never realized the browser was presenting a user-friendly version of the URL, showing the [], but if you copy and past the URL they are converted to %5B%5D.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2021

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272395: Bad HTML in JVMTI man page

Reviewed-by: dholmes, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 10db0e4: 8277932: Subject:callAs() not throwing NPE when action is null
  • f148e3e: 8278318: Create {@Index} entries for key LangTools terms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 7, 2021
@sspitsyn
Copy link
Contributor Author

@sspitsyn sspitsyn commented Dec 7, 2021

Thank you for review, David and Iris!

@sspitsyn
Copy link
Contributor Author

@sspitsyn sspitsyn commented Dec 7, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2021

Going to push as commit e535cb3.
Since your change was applied there have been 3 commits pushed to the master branch:

  • f22d157: 8277353: java/security/MessageDigest/ThreadSafetyTest.java test times out
  • 10db0e4: 8277932: Subject:callAs() not throwing NPE when action is null
  • f148e3e: 8278318: Create {@Index} entries for key LangTools terms

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2021

@sspitsyn Pushed as commit e535cb3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sspitsyn sspitsyn deleted the br4 branch Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated serviceability
3 participants