New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8272395: Bad HTML in JVMTI man page #6730
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
I never realized the browser was presenting a user-friendly version of the URL, showing the [], but if you copy and past the URL they are converted to %5B%5D.
Thanks,
David
@sspitsyn This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Thank you for review, David and Iris! |
/integrate |
Going to push as commit e535cb3.
Your commit was automatically rebased without conflicts. |
This fix adds escaping of invalid characters '[]' for 3 URLs defined in the jvmti.xml.
This file is a base to generate the jvmti.html.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6730/head:pull/6730
$ git checkout pull/6730
Update a local copy of the PR:
$ git checkout pull/6730
$ git pull https://git.openjdk.java.net/jdk pull/6730/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6730
View PR using the GUI difftool:
$ git pr show -t 6730
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6730.diff