8278330: dump stack trace if the jvmti test nsk/jvmti/GetThreadState/thrstat002 is failed with wrong thread state #6735

sspitsyn · 2021-12-07T09:12:53Z

This is a fix for sub-task of:
8271065: vmTestbase/nsk/jvmti/GetThreadState/thrstat002 still fails with "Wrong thread "thr1" (...) state after SuspendThread"

The vmTestbase/nsk/jvmti/GetThreadState/thrstat002 test is intermittently failing with the wrong thread state reported.
It is most likely because of the unexpected JFR (or NMT) activity.
In order to confirm this guess we need to dump the stack trace in a case of this failure.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8278330: dump stack trace if the jvmti test nsk/jvmti/GetThreadState/thrstat002 is failed with wrong thread state

Reviewers

Alex Menkov (@alexmenkov - Reviewer)
Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6735/head:pull/6735
$ git checkout pull/6735

Update a local copy of the PR:
$ git checkout pull/6735
$ git pull https://git.openjdk.java.net/jdk pull/6735/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6735

View PR using the GUI difftool:
$ git pr show -t 6735

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6735.diff

…State/thrstat002 is failed with wrong thread state

bridgekeeper · 2021-12-07T09:13:19Z

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-12-07T09:15:26Z

@sspitsyn The following label will be automatically applied to this pull request:

serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-12-07T09:20:29Z

Webrevs

01: Full - Incremental (7e703a52)
00: Full (f85565e6)

alexmenkov · 2021-12-07T20:19:29Z

test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetThreadState/thrstat002/thrstat002.cpp

+
+  cname = get_method_class_name(jvmti, jni, method);
+
+  err = jvmti->GetMethodName(method, &mname, &msign, NULL);


Need to deallocate returned mname/msig

Thanks, fixed.

alexmenkov · 2021-12-07T20:21:47Z

test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetThreadState/thrstat002/thrstat002.cpp

+  err = jvmti->GetMethodDeclaringClass(method, &klass);
+  check_jvmti_status(jni, err, "get_method_class_name: error in JVMTI GetMethodDeclaringClass");
+
+  err = jvmti->GetClassSignature(klass, &cname, NULL);


Need to deallocate returned strings

Thanks, fixed.

alexmenkov · 2021-12-07T20:23:17Z

test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetThreadState/thrstat002/thrstat002.cpp

+  char*  msign = NULL;
+  jvmtiError err;
+
+  cname = get_method_class_name(jvmti, jni, method);


Need to deallocate returned string

Thanks, fixed.

lmesnik · 2021-12-07T21:21:35Z

test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetThreadState/thrstat002/thrstat002.cpp

@@ -48,6 +48,104 @@ static jint state[] = {
    JVMTI_THREAD_STATE_IN_OBJECT_WAIT
 };

+#define DBG 1


I don't think that DBG really needs to be disabled, just print info anytime when test fails

I used these ifdef's to easily identify the debugging/utility fragments in a case we want to isolate it in test library. It does not harm anyway. Okay, I've decided to replace '#ifdef DBG' with '#if 1'

lmesnik

Looks good.

openjdk · 2021-12-07T22:27:53Z

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278330: dump stack trace if the jvmti test nsk/jvmti/GetThreadState/thrstat002 is failed with wrong thread state

Reviewed-by: amenkov, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

b3faecf: 8276116: C2: optimize long range checks in int counted loops
fe2ae8e: 8276904: Optional.toString() is unnecessarily expensive
6e7b7f3: 8278251: Enable "missing-explicit-ctor" check in the jdk.unsupported.desktop module
c83b781: 8278459: ProblemList javax/swing/JTree/4908142/bug4908142.java on macosx-aarch64
8e8fadf: 8278428: ObjectInputStream.readFully range check incorrect
5a80abf: 8272944: Use snippets in jdk.javadoc documentation
fb11d8f: 8272945: Use snippets in java.compiler documentation
42d9b1b: 8277106: Cannot compile certain sources with --release
ba86dd4: 8278445: ProblemList tools/jpackage/share/IconTest.java on macosx-x64
92aa75b: 8274903: Zero: Support AsyncGetCallTrace
... and 47 more: https://git.openjdk.java.net/jdk/compare/2ff12966a345eaa1c16ed73165b3eb273e56f8dd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

sspitsyn · 2021-12-08T22:31:00Z

/integrate

openjdk · 2021-12-08T22:32:14Z

Going to push as commit 3893f4f.
Since your change was applied there have been 57 commits pushed to the master branch:

b3faecf: 8276116: C2: optimize long range checks in int counted loops
fe2ae8e: 8276904: Optional.toString() is unnecessarily expensive
6e7b7f3: 8278251: Enable "missing-explicit-ctor" check in the jdk.unsupported.desktop module
c83b781: 8278459: ProblemList javax/swing/JTree/4908142/bug4908142.java on macosx-aarch64
8e8fadf: 8278428: ObjectInputStream.readFully range check incorrect
5a80abf: 8272944: Use snippets in jdk.javadoc documentation
fb11d8f: 8272945: Use snippets in java.compiler documentation
42d9b1b: 8277106: Cannot compile certain sources with --release
ba86dd4: 8278445: ProblemList tools/jpackage/share/IconTest.java on macosx-x64
92aa75b: 8274903: Zero: Support AsyncGetCallTrace
... and 47 more: https://git.openjdk.java.net/jdk/compare/2ff12966a345eaa1c16ed73165b3eb273e56f8dd...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-12-08T22:32:32Z

@sspitsyn Pushed as commit 3893f4f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

fixed: 8278330 dump stack trace if the jvmti test nsk/jvmti/GetThread…

f85565e

…State/thrstat002 is failed with wrong thread state

openjdk bot added the rfr Pull request is ready for review label Dec 7, 2021

openjdk bot added the serviceability serviceability-dev@openjdk.org label Dec 7, 2021

alexmenkov suggested changes Dec 7, 2021

View reviewed changes

lmesnik suggested changes Dec 7, 2021

View reviewed changes

add missing deallocate to avoid memory leaks

7e703a5

lmesnik approved these changes Dec 7, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 7, 2021

alexmenkov approved these changes Dec 8, 2021

View reviewed changes

openjdk bot closed this Dec 8, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2021

sspitsyn deleted the br5 branch May 24, 2022 05:08

8278330: dump stack trace if the jvmti test nsk/jvmti/GetThreadState/thrstat002 is failed with wrong thread state #6735

8278330: dump stack trace if the jvmti test nsk/jvmti/GetThreadState/thrstat002 is failed with wrong thread state #6735

sspitsyn commented Dec 7, 2021 •

edited by openjdk bot

bridgekeeper bot commented Dec 7, 2021

openjdk bot commented Dec 7, 2021

mlbridge bot commented Dec 7, 2021 •

edited

alexmenkov Dec 7, 2021

sspitsyn Dec 7, 2021

alexmenkov Dec 7, 2021

sspitsyn Dec 7, 2021

alexmenkov Dec 7, 2021

sspitsyn Dec 7, 2021

lmesnik Dec 7, 2021

sspitsyn Dec 7, 2021 •

edited

lmesnik left a comment

openjdk bot commented Dec 7, 2021 •

edited

sspitsyn commented Dec 8, 2021

openjdk bot commented Dec 8, 2021

openjdk bot commented Dec 8, 2021


		cname = get_method_class_name(jvmti, jni, method);

		err = jvmti->GetMethodName(method, &mname, &msign, NULL);

8278330: dump stack trace if the jvmti test nsk/jvmti/GetThreadState/thrstat002 is failed with wrong thread state #6735

8278330: dump stack trace if the jvmti test nsk/jvmti/GetThreadState/thrstat002 is failed with wrong thread state #6735

Conversation

sspitsyn commented Dec 7, 2021 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Dec 7, 2021

openjdk bot commented Dec 7, 2021

mlbridge bot commented Dec 7, 2021 • edited

Webrevs

alexmenkov Dec 7, 2021

Choose a reason for hiding this comment

sspitsyn Dec 7, 2021

Choose a reason for hiding this comment

alexmenkov Dec 7, 2021

Choose a reason for hiding this comment

sspitsyn Dec 7, 2021

Choose a reason for hiding this comment

alexmenkov Dec 7, 2021

Choose a reason for hiding this comment

sspitsyn Dec 7, 2021

Choose a reason for hiding this comment

lmesnik Dec 7, 2021

Choose a reason for hiding this comment

sspitsyn Dec 7, 2021 • edited

Choose a reason for hiding this comment

lmesnik left a comment

Choose a reason for hiding this comment

openjdk bot commented Dec 7, 2021 • edited

sspitsyn commented Dec 8, 2021

openjdk bot commented Dec 8, 2021

openjdk bot commented Dec 8, 2021

sspitsyn commented Dec 7, 2021 •

edited by openjdk bot

mlbridge bot commented Dec 7, 2021 •

edited

sspitsyn Dec 7, 2021 •

edited

openjdk bot commented Dec 7, 2021 •

edited