Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout #6740

Closed
wants to merge 4 commits into from

Conversation

dfuch
Copy link
Member

@dfuch dfuch commented Dec 7, 2021

The three tests:

test/jdk/java/net/httpclient/ManyRequests.java
test/jdk/java/net/httpclient/ManyRequests2.java
test/jdk/java/net/httpclient/ManyRequestsLegacy.java

have been observed failing intermittently with ConnectException on windows 10 machines in our CI.
These tests open 20 concurrent requests each, and the suspicion is that when these tests run concurrently on the same machine they may cross some OS throttling threshold that causes the connection to be rejected.

The tests had a built-in mechanism to throttle the number of requests running concurrently, but it was not used.
The fix is to enable this mechanism on windows, limiting the concurrency to 10 requests, if the first run of the test fails with a ConnectException.

With this in place I am no longer observing any failure (was 1 to 3 failures for every 50 runs before)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6740/head:pull/6740
$ git checkout pull/6740

Update a local copy of the PR:
$ git checkout pull/6740
$ git pull https://git.openjdk.java.net/jdk pull/6740/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6740

View PR using the GUI difftool:
$ git pr show -t 6740

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6740.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 7, 2021

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2021

@dfuch The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net label Dec 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 7, 2021

Webrevs

});
}
boolean done = false;
LOOP: do {
Copy link
Member

@Michael-Mc-Mahon Michael-Mc-Mahon Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a comment here indicating the purpose of the loop in terms of catching ConnectException (only) and what happens in terms of the reduction of the request concurrency?

});
}
boolean done = false;
LOOP: do {
Copy link
Member

@Michael-Mc-Mahon Michael-Mc-Mahon Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as for ManyRequests

Copy link
Member

@Michael-Mc-Mahon Michael-Mc-Mahon left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2021

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout

Reviewed-by: michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • fd8cb2d: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine
  • e5cb84e: 8278336: Use int64_t to represent byte quantities consistently in JfrObjectAllocationSample

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 8, 2021
@dfuch
Copy link
Member Author

@dfuch dfuch commented Dec 8, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2021

Going to push as commit 37921e3.
Since your change was applied there have been 2 commits pushed to the master branch:

  • fd8cb2d: 8278346: java/nio/file/Files/probeContentType/Basic.java fails on Linux SLES15 machine
  • e5cb84e: 8278336: Use int64_t to represent byte quantities consistently in JfrObjectAllocationSample

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2021

@dfuch Pushed as commit 37921e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated net
2 participants